Skip to content

fix: yarn binary is now run from separate @yarn repo #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeagle merged 1 commit into from
Nov 8, 2022
Merged

fix: yarn binary is now run from separate @yarn repo #3597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/Built-ins.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions internal/npm_install/npm_install.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ def _yarn_install_impl(repository_ctx):
elif yarn_version == "classic":
# Set frozen lockfile as default install to install the exact version from the yarn.lock
# file. To perform an yarn install use the vendord yarn binary with:
# `bazel run @nodejs_host//:yarn install` or `bazel run @nodejs_host//:yarn install -- -D <dep-name>`
# `bazel run @yarn//:yarn install` or `bazel run @yarn//:yarn install -- -D <dep-name>`
if repository_ctx.attr.frozen_lockfile:
yarn_args.append("--frozen-lockfile")

Expand Down Expand Up @@ -1025,8 +1025,8 @@ This flag enables an exact install of the version that is specified in the `yarn
file. This helps to have reproducible builds across builds.

To update a dependency or install a new one run the `yarn install` command with the
vendored yarn binary. `bazel run @nodejs_host//:yarn install`. You can pass the options like
`bazel run @nodejs_host//:yarn install -- -D <dep-name>`.
vendored yarn binary. `bazel run @yarn//:yarn install`. You can pass the options like
`bazel run @yarn//:yarn install -- -D <dep-name>`.
""",
),
"use_global_yarn_cache": attr.bool(
Expand Down