Skip to content

feat: enable rules_python Starlark implemention by default for Bazel 7+ #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 3 commits into from
Feb 13, 2024
Merged

feat: enable rules_python Starlark implemention by default for Bazel 7+ #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0880bf
feat: enable rules_python Starlark implemention by default for Bazel 7+
rickeylev Jan 17, 2024
e1fbc68
add changelog
rickeylev Jan 23, 2024
6fce378
Merge branch 'main' of ssh://ssh.github.com:443/bazelbuild/rules_pyth…
rickeylev Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ A brief description of the categories of changes:

### Changed

* For Bazel 7, the core rules and providers are now implemented in rules_python
directly and the rules bundled with Bazel are not used. Bazel 6 and earlier
continue to use the Bazel builtin symbols. Of particular note, this means,
under Bazel 7, the builtin global symbol `PyInfo` is **not** the same as what
is loaded from rules_python. The same is true of `PyRuntimeInfo`.

* (toolchains) Windows hosts always ignore pyc files in the downloaded runtimes.
This fixes issues due to pyc files being created at runtime and affecting the
definition of what files were considered part of the runtime.
Expand Down
2 changes: 1 addition & 1 deletion python/private/internal_config_repo.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ settings for rules to later use.
"""

_ENABLE_PYSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PYSTAR"
_ENABLE_PYSTAR_DEFAULT = "0"
_ENABLE_PYSTAR_DEFAULT = "1"

_CONFIG_TEMPLATE = """\
config = struct(
Expand Down