Add missing run_tag directive.#1995
Merged
alexeagle merged 1 commit intobazelbuild:masterfrom Jan 9, 2022
Merged
Conversation
Contributor
Author
|
This might need to be merged quickly to unbreak |
Contributor
|
+1 on adding some missing e2e for this, thank you. Will merge this now to unbreak HEAD, thanks for explaining your analysis of what happened. |
alexeagle
approved these changes
Jan 9, 2022
Contributor
Author
|
Just confirmed that behavior is as expected post-merge on Tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
docker runcommand fails because it is missing arun_tagarg due to a missing line merged in #1957.Issue Number: N/A
What is the new behavior?
The
docker runcommand succeeds and runs as per documentation.Does this PR introduce a breaking change?
Other information
The line
"%{run_tag}": run_tag,was omitted during this merge commit:922e466#diff-2a6edca3d784a368586063a7774b7551bbf4476c7345c511ab987bf95c610527L281
Referenced in this comment on the original PR:
#1957 (comment)