Replace python with python3 in incremental_load.sh.tpl#2051
Merged
linzhp merged 2 commits intobazelbuild:masterfrom Apr 15, 2022
Merged
Replace python with python3 in incremental_load.sh.tpl#2051linzhp merged 2 commits intobazelbuild:masterfrom
linzhp merged 2 commits intobazelbuild:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Contributor
Author
|
I think I did sign it @linzhp |
linzhp
approved these changes
Apr 14, 2022
linzhp
requested changes
Apr 14, 2022
Co-authored-by: Zhongpeng Lin <zplin@uber.com>
linzhp
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On MacOS 12.3, Apple removed the default
pythonexecutable.Building images doesn't work and throw this error:
env: python: No such file or directoryIssue Number: #2046 2046
What is the new behavior?
Build on a system without
pythonexecutable (as MacOS 12.3+) works as expected.Does this PR introduce a breaking change?
Other information