Disable cache for install_pkgs_reproducibility_test deps - #2071
Closed
laurynaslubys wants to merge 1 commit into
Closed
Disable cache for install_pkgs_reproducibility_test deps#2071laurynaslubys wants to merge 1 commit into
laurynaslubys wants to merge 1 commit into
Conversation
laurynaslubys
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
April 25, 2022 13:56
laurynaslubys
force-pushed
the
fix-repro-test
branch
from
April 25, 2022 14:50
0a1333c to
273c5d3
Compare
download_pkgs is not hermetic as it goes out to the package repository to fetch packages. If the remote apt repository gets updated, the bazel cache can get into a weird state.
laurynaslubys
force-pushed
the
fix-repro-test
branch
from
April 25, 2022 15:50
273c5d3 to
97184e0
Compare
Contributor
Author
|
This may have accidentally been caused by #2043 |
laurynaslubys
changed the title
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
github-actions
Bot
added
the
Can Close?
|
This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker rules are not hermetic as the sha of layers depends on the modification times of files inside containers.
If the the containers get cached from different runs, they will have different sha sums.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some PRs (#1439 #2068) are blocked on //tests/docker/package_managers:install_pkgs_reproducibility_test failing.
Does this PR introduce a breaking change?
Other information