Incremental load support for commit and extract. - #2208
Conversation
Signed-off-by: Thomas Lam <thomaslam@canva.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Sorry to ask this of you @uhthomas but given the effort put into #1439 that didn't pan out I'm hesitant to spend more time on this, can you take this over? @lamcw looks like the CLA check is failing because you're the author of the commit, can you submit one via https://cla.developers.google.com? |
|
I understand @uri-canva, no worries. I can't guarantee I'll get round to it though I appreciate you making the effort to update this PR with your latest changes. |
Signed-off-by: Thomas Lam <thomaslam@canva.com>
Signed-off-by: Thomas Lam <thomaslam@canva.com>
Signed-off-by: Thomas Lam <thomaslam@canva.com>
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
container_run_and_commitandcontainer_run_and_extractdon't support the intermediate format because they were moved from https://github.com/GoogleContainerTools/base-images-docker.Issue Number: 1384
What is the new behavior?
Support incremental loading in the two rules so that they can depend on
container_imagerules' layer outputs instead of having to depend on the image tarball.Does this PR introduce a breaking change?
Other information
More context in the previous attempt: #1439.