Skip to content

Fix runfiles discovery#522

Merged
nlopezgi merged 1 commit intobazelbuild:masterfrom
scele:fix_runfiles_discovery
Oct 5, 2018
Merged

Fix runfiles discovery#522
nlopezgi merged 1 commit intobazelbuild:masterfrom
scele:fix_runfiles_discovery

Conversation

@scele
Copy link
Contributor

@scele scele commented Sep 15, 2018

The launcher scripts were not able to find runfiles when executed
deeper inside a runfile tree generated by another rule. This
happens when another rule depends on the container image target
and wants to execute the scripts from its own runfiles tree.

Fix discovery to also account for this possibility, using similar
heuristics as FindModuleSpace in the python launcher.

@xingao267
Copy link
Contributor

Hi @scele thanks for you contribution. Can you provide some test cases for this?

@xingao267
Copy link
Contributor

Here of places where you can add the tests:

And it would be nice if you can provide a bit more comments in the code.

Thanks again for your contribution!

@nlopezgi
Copy link
Contributor

nlopezgi commented Oct 3, 2018

Hi @scele, please let me know if you are having issues creating a test for this so we can help you out.

The launcher scripts were not able to find runfiles when executed
deeper inside a runfile tree generated by another rule.  This
happens when another rule depends on the container image target
and wants to execute the scripts from its own runfiles tree.

Fix discovery to also account for this possibility, using similar
heuristics as FindModuleSpace in the python launcher.
@scele scele force-pushed the fix_runfiles_discovery branch from daf0437 to 0f02237 Compare October 4, 2018 21:23
@scele
Copy link
Contributor Author

scele commented Oct 4, 2018

Added test coverage and a few comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants