Merged
Conversation
Contributor
|
Hi @scele thanks for you contribution. Can you provide some test cases for this? |
Contributor
|
Here of places where you can add the tests:
And it would be nice if you can provide a bit more comments in the code. Thanks again for your contribution! |
Contributor
|
Hi @scele, please let me know if you are having issues creating a test for this so we can help you out. |
The launcher scripts were not able to find runfiles when executed deeper inside a runfile tree generated by another rule. This happens when another rule depends on the container image target and wants to execute the scripts from its own runfiles tree. Fix discovery to also account for this possibility, using similar heuristics as FindModuleSpace in the python launcher.
daf0437 to
0f02237
Compare
Contributor
Author
|
Added test coverage and a few comments! |
nlopezgi
approved these changes
Oct 5, 2018
This was referenced Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launcher scripts were not able to find runfiles when executed
deeper inside a runfile tree generated by another rule. This
happens when another rule depends on the container image target
and wants to execute the scripts from its own runfiles tree.
Fix discovery to also account for this possibility, using similar
heuristics as FindModuleSpace in the python launcher.