Skip to content

exec docker run statement.#667

Merged
nlopezgi merged 1 commit intobazelbuild:masterfrom
Globegitter:exec-docker-run
Jan 16, 2019
Merged

exec docker run statement.#667
nlopezgi merged 1 commit intobazelbuild:masterfrom
Globegitter:exec-docker-run

Conversation

@Globegitter
Copy link

@Globegitter Globegitter commented Jan 16, 2019

We are running into some smaller issues, where we want to run the binary output of the x_image rules in another script, but then when this script wants to gracefully terminate all its child processes it only kills the bash process but not the docker run it executed. As far as I can tell (and from testing) the cleanup function does not do anything in this case so it should also be no problem that it is not getting called anymore.

And in general I think it is nicer in a case like this, where we have a wrapper script that just sets up a few things before executing a single binary that this binary then becomes the main process.

@k8s-ci-robot
Copy link

Hi @Globegitter. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Globegitter
Copy link
Author

/assign @nlopezgi

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Globegitter, nlopezgi
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi nlopezgi merged commit 281df71 into bazelbuild:master Jan 16, 2019
@Globegitter Globegitter deleted the exec-docker-run branch January 17, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants