Conversation
|
Hi @Globegitter. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @nlopezgi |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Globegitter, nlopezgi If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
We are running into some smaller issues, where we want to run the binary output of the x_image rules in another script, but then when this script wants to gracefully terminate all its child processes it only kills the bash process but not the docker run it executed. As far as I can tell (and from testing) the
cleanupfunction does not do anything in this case so it should also be no problem that it is not getting called anymore.And in general I think it is nicer in a case like this, where we have a wrapper script that just sets up a few things before executing a single binary that this binary then becomes the main process.