Skip to content

Add error message when docker is not available in incremental loader#731

Merged
nlopezgi merged 2 commits intobazelbuild:masterfrom
clintharrison:docker-missing-error
Mar 19, 2019
Merged

Add error message when docker is not available in incremental loader#731
nlopezgi merged 2 commits intobazelbuild:masterfrom
clintharrison:docker-missing-error

Conversation

@clintharrison
Copy link
Contributor

Right now, when docker is not found through the default-configured toolchain, the error message ends up being quite opaque:

my/target: line 202: : command not found

@k8s-ci-robot
Copy link

Hi @clintharrison. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smukherj1
Copy link
Collaborator

@nlopezgi Can you take a look? Overall this makes sense to me because we don't emit any error messages when building containers if docker isn't found. However, using bazel run on the built container will result in an obscure error message as @clintharrison pointed out. It makes sense to give a more visible error message if the docker path in the incremental loader shell script is blank.

@nlopezgi
Copy link
Contributor

thanks, I'll take a look early next week

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clintharrison, nlopezgi
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 19, 2019
@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@nlopezgi nlopezgi merged commit 92a497d into bazelbuild:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants