Add error message when docker is not available in incremental loader#731
Conversation
|
Hi @clintharrison. Thanks for your PR. I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nlopezgi Can you take a look? Overall this makes sense to me because we don't emit any error messages when building containers if docker isn't found. However, using bazel run on the built container will result in an obscure error message as @clintharrison pointed out. It makes sense to give a more visible error message if the docker path in the incremental loader shell script is blank. |
|
thanks, I'll take a look early next week |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clintharrison, nlopezgi If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Right now, when
dockeris not found through the default-configured toolchain, the error message ends up being quite opaque:my/target: line 202: : command not found