Add includes option to ruby_bundle rule for per-gem load path customization#102
Merged
kigster merged 20 commits intobazelruby:masterfrom Jul 9, 2021
Merged
Conversation
added 9 commits
July 4, 2021 11:01
This was
linked to
issues
Jul 7, 2021
Contributor
Author
|
Thank you for updating the CI settings. I will look into the errors: https://app.circleci.com/pipelines/github/bazelruby/rules_ruby/307/workflows/bdd3ad88-e478-4e37-8029-b16e3ef1b38e/jobs/1073 |
Contributor
|
@mmizutani Keep in mind that ruby version went up to 3.0.1 across the board. Perhaps you might want to update it as well, so that on CI we don't need to build a 2.7 interpreter. The 3.0.1 is pulled with the Docker image. |
Contributor
|
This, once ready, will be the 0.5.1 release. |
Contributor
|
Let me know if you'd like to pair on figuring out the broken build issues. I am in San Francisco time zone. |
Contributor
Author
|
The tests have now been fixed. Thank you for your advice. |
Contributor
|
Amazing! |
kigster
approved these changes
Jul 9, 2021
Contributor
kigster
left a comment
There was a problem hiding this comment.
LGTM — there are couple of small clarifications, otherwise good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the gem registration logics to load all of the paths specified in the
require_pathsproperty of gemspecsinstead of loading only the standard, hardcoded path
["lib"].Also, this PR extends
ruby_bundlerule to also acceptincludesoption, which allows us to specify additional library load paths not listed in the gemspecs'require_pathsfor specific rubygems like this:With both
includesandexcludesper-gem options at hand, users ofruby_bundlerule have more granular control over gem load paths, possibly addressing issues #85 , #86 , #97.