-
-
Notifications
You must be signed in to change notification settings - Fork 588
Add projectile-cache-file to projectile-globally-ignored-files default #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as safe - Include projectile-cache-file in projectile-globally-ignored-files default - Add :safe predicate to allow dir-locals configuration - Add tests for default values and :safe predicate validation
bbatsov
approved these changes
Jan 7, 2026
Owner
|
Can you rebase on top of master to address the changelog conflict? |
Contributor
Author
|
I updated!! |
Owner
|
Seems there's a failing test now: |
Contributor
Author
- Update related file and test matching functions to use let* variants - Improve variable binding consistency and future compatibility
Owner
|
Yep, the CI is green now. Thanks! I still see this, though:
Probably you'll need to rebase on your branch on top of |
- Remove duplicate entries for issues bbatsov#1957 and bbatsov#1954 - Merge split lines for clarity on projectile-auto-discover default - Ensure changelog accurately reflects recent changes
Contributor
Author
|
Resolved conflict!! |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1958 - Exclude
.projectile-cache.eldfrom search results by default.Changes
projectile-cache-fileto the default value ofprojectile-globally-ignored-filesRationale
The cache file is an internal file generated by projectile and should not appear in search results. This is consistent with how
projectile-tags-file-name(TAGS) is already excluded by default.