Skip to content

Conversation

@takeokunn
Copy link
Contributor

Summary

Fix #1958 - Exclude .projectile-cache.eld from search results by default.

Changes

  • Add projectile-cache-file to the default value of projectile-globally-ignored-files
  • This prevents the cache file from appearing in ripgrep/ag/grep search results

Rationale

The cache file is an internal file generated by projectile and should not appear in search results. This is consistent with how projectile-tags-file-name (TAGS) is already excluded by default.

…as safe

- Include projectile-cache-file in projectile-globally-ignored-files default
- Add :safe predicate to allow dir-locals configuration
- Add tests for default values and :safe predicate validation
@takeokunn takeokunn marked this pull request as ready for review January 3, 2026 06:17
@bbatsov
Copy link
Owner

bbatsov commented Jan 7, 2026

Can you rebase on top of master to address the changelog conflict?

@takeokunn
Copy link
Contributor Author

I updated!!

@bbatsov
Copy link
Owner

bbatsov commented Jan 8, 2026

Seems there's a failing test now:

projectile-ignored-files returns list of ignored files
FAILED: Expected `(projectile-ignored-files)' to be `equal' to `("/path/to/project/TAGS" "/path/to/project/foo.js" "/path/to/project/bar.rb")', but instead it was `("/path/to/project/TAGS" "/path/to/project/.projectile-cache.eld" "/path/to/project/foo.js" "/path/to/project/bar.rb")' which does not match because: (proper-lists-of-different-length 4 3 ("/path/to/project/TAGS" "/path/to/project/.projectile-cache.eld" "/path/to/project/foo.js" "/path/to/project/bar.rb") ("/path/to/project/TAGS" "/path/to/project/foo.js" "/path/to/project/bar.rb") first-mismatch-at 1).

Ran 203 specs, 1 failed, in 1.25s.
[00:03.938]  1 Buttercup test failed

@takeokunn
Copy link
Contributor Author

takeokunn commented Jan 8, 2026

@bbatsov
Fix CI error! 7318a77 0432e8f

- Update related file and test matching functions to use let* variants
- Improve variable binding consistency and future compatibility
@bbatsov
Copy link
Owner

bbatsov commented Jan 9, 2026

Yep, the CI is green now. Thanks!

I still see this, though:

This branch cannot be rebased due to conflicts

Probably you'll need to rebase on your branch on top of master once more and perhaps squash all commits into 1.

- Remove duplicate entries for issues bbatsov#1957 and bbatsov#1954
- Merge split lines for clarity on projectile-auto-discover default
- Ensure changelog accurately reflects recent changes
@takeokunn
Copy link
Contributor Author

takeokunn commented Jan 9, 2026

Resolved conflict!!

@bbatsov bbatsov merged commit f19262a into bbatsov:master Jan 9, 2026
6 checks passed
@bbatsov
Copy link
Owner

bbatsov commented Jan 9, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: projectile-ripgrep should ignore .projectile-cache.eld file

2 participants