This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Fixed the response image width=0 bug when data-width is not set - #83
Merged
Conversation
thom4parisot
modified the milestones:
0.2.0 - Features Improvements,
0.3.0 - Lazyloading Stability
|
This threw me for a loop yesterday. :( |
|
This threw me for a loop as well. |
thom4parisot
modified the milestones:
0.3.0 – Convenience features,
0.3.0 - Lazyloading Stability
`data-width` should be copied only if set.
Contributor
Author
|
With this PR the image width attribute is set only when it's set. This way the container is driving the image sizing, unless you really want to force it. Let me know if that works for you, especially @nhoizey :-) |
thom4parisot
pushed a commit
that referenced
this pull request
Mar 20, 2014
Image width is set as 0 sometimes
thom4parisot
changed the title
width=0 bug when data-width is not set
|
Seems to work well! \o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example here: http://lab.gasteroprod.com/imager/ex01/
The container width has to be explicitly set to 100% for example.
Imager should at least pick 320 if the width is not properly picked up.
Props of @nhoizey