This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Fixed breakpoint selection: it always opt-in for the biggest available breakpoint to fit the container size - #86
Merged
Merged
Conversation
Contributor
|
@ChrisBAshton All explained perfectly. Thanks for raising this issue. |
`data-width` should be copied only if set.
- definitely sorting out the relationship with image size and `data-width` - expanding image based on container's size
Thanks Past Me for documenting it!
Contributor
|
The tests fails but basically it has to be related with the max screen size of the iPhone (which is smaller that 1024 in portrait mode). |
thom4parisot
pushed a commit
that referenced
this pull request
Mar 20, 2014
Containers above max image size load smallest image
thom4parisot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I had a container div with no width or max width set. My maximum image size in Imager was 976px. Imager works as normal when my browser resizes anywhere beneath 976px, but the moment my viewport (and therefore the container div) is wider than 976px, Imager defaults to the smallest image (320px).
So the effect goes from 976px - fine => 977px - blurry, when the expected behaviour is to keep the largest possible image.
Hope I've explained everything sufficiently!