Add text border for visiblilty of long strings#307
Merged
microbit-carlos merged 4 commits intoNov 26, 2019
Conversation
update fork
Make long strings text visable
microbit-josephine
changed the title
Collaborator
|
Thanks Josephine! Could you list what browsers and resolutions you've tested this PR on? |
Contributor
Author
|
Passes on: IE10, IE11, Edge, Windows Firefox, Mac Firefox, Chrome and safari |
update branch
Collaborator
|
Great, thanks Josephine. Could you also include a before an after screenshot in the opening message? They are really useful to see what the PR is doing, you can just use the screenshots we already have in platform software, no need to create new ones. |
microbit-carlos
approved these changes
Nov 26, 2019
microbit-carlos
left a comment
microbit-carlos
left a comment
Collaborator
There was a problem hiding this comment.
Great, thanks Josephine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: