Docs: update for RGBW neopixel#694
Conversation
Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
microbit-carlos
left a comment
There was a problem hiding this comment.
V2 also has fill and clear, could you check if those are available for V1 as well?
https://github.com/microbit-foundation/micropython-microbit-v2/blob/6a4b97ffce97a41a593e77553a82e24e59b7107c/src/codal_port/modules/neopixel.py
Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
|
V1 has |
|
I've updated to add the V2 methods in 9641853 Not sure on how best to present Also not sure on how to present arguments for |
Yeah, they are equivalent. The current text is good, although if you need to edit the file anyway I might remove
Showing the tuple would be difficult, as the length depends on how many bytes per pixel. I think it's fine to just name the argument |
|
Perfect, thanks Mark! |
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
Based on the changes added to the V2 documentation from PR bbcmicrobit#694 Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
Based on the changes added to the V2 documentation from PR bbcmicrobit#694 Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
Based on the changes added to the V2 documentation from PR bbcmicrobit#694 Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* docs: Update V1 neopixel module support for RGBW. Based on the changes added to the V2 documentation from PR #694 Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * docs: Fix typo in NeoPixel module. Co-authored-by: Mark <mark@microbit.org> Co-authored-by: Mark <mark@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <carlos@microbit.org>
Doc update to include support for RGBW Neopixels. I haven't tested this on hardware, so making an assumption that the values are in the order written eg
np[0]= (R, G, B, W)as opposed to GRBW which I think is the default for NeoPixelsand we order them here https://github.com/microbit-foundation/micropython-microbit-v2/blob/6a4b97ffce97a41a593e77553a82e24e59b7107c/src/codal_port/modules/neopixel.py#L19