docs: Improve microphone description, add more info for set_threshold().#804
Merged
microbit-carlos merged 2 commits intobbcmicrobit:v2-docsfrom Apr 12, 2024
Merged
Conversation
microbit-carlos
commented
Apr 12, 2024
Collaborator
Author
microbit-carlos
left a comment
microbit-carlos
left a comment
There was a problem hiding this comment.
I need to update the recording & playback docs, which also touch these files, so I'll merge this now and rebase the other doc branches accordingly.
microbit-carlos
added a commit
that referenced
this pull request
May 7, 2024
…d()`. (#804) * docs: Improve descriptions for microphone module. * docs: Add more info to `microphone.set_threshold()`.
microbit-carlos
added a commit
that referenced
this pull request
Jul 18, 2024
…d()`. (#804) * docs: Improve descriptions for microphone module. * docs: Add more info to `microphone.set_threshold()`.
microbit-carlos
added a commit
that referenced
this pull request
Sep 16, 2024
…d()`. (#804) * docs: Improve descriptions for microphone module. * docs: Add more info to `microphone.set_threshold()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The improvements are taken from micropython-microbit-stubs/lang/en/typeshed/stdlib/microbit/microphone.pyi, the additional
set_threshold()from lancaster-university/codal-core#167.@microbit-matt-hillsdon @microbit-grace ad7e00f shows a better diff for the stubs, but please feel free to review these changes if you'd like.
Preview URL: https://microbit-micropython--804.org.readthedocs.build/en/804/microphone.html