Skip to content

2551 Add new FF for priority wait time tooltip #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eve-git merged 1 commit into from
Nov 19, 2025
Merged

2551 Add new FF for priority wait time tooltip #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.8.3",
"version": "5.8.4",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
17 changes: 14 additions & 3 deletions app/src/components/new-request/stats.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@
</div>
</template>
<span>
If you need your name reviewed as quickly as possible, Priority requests
are available for a fee ($100.00). Priority name requests are usually
reviewed within 1 to 2 business days.
{{ priorityToolTipText }}
</span>
</v-tooltip>
</v-col>
Expand Down Expand Up @@ -173,6 +171,19 @@ export default class Stats extends Vue {
const val = Number(this.priorityWaitTime)
return Number.isFinite(val) && val > 0
}

get priorityToolTipText (): string {
const priorityToolTipText = GetFeatureFlag('priority-wait-time-tooltip-text')
if (priorityToolTipText) {
return priorityToolTipText
}
// Return default text when no priority tooltip text is available from the feature flag
return `
Copy link
Collaborator

@hfekete hfekete Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to see any tooltip for priority on the test page. Can you share the example how it will look like when flag is on, and when there is no flag ?

I did see the tooltip for the "New submission time"

Thank you!

Image

Copy link
Collaborator Author

@eve-git eve-git Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the days value is disabled, the tooltip doesn’t appear. If you set the priority days to a value greater than zero, the tooltip will show up.

Copy link
Collaborator

@hfekete hfekete Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If thats expected behavior then its OK
It would be good to have a sample if you have available how it will look like with FF turned on.

If you need your name reviewed as quickly as possible,
Priority requests are available for a fee ($100.00).
Priority name requests are usually reviewed within 1 to 2 business days.
`.trim()
}
}
</script>

Expand Down
1 change: 1 addition & 0 deletions app/src/plugins/launchDarkly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const defaultFlagSet: LDFlagSet = {
'enable-web-chat': false, // by default, old webchat is disabled
'hardcoded_priority_wait_time': 0, // by default, use actual wait time
'hardcoded_regular_wait_time': 0, // by default, use actual wait time
'priority-wait-time-tooltip-text': '', // by default, display default tooltip text
'supported-amalgamation-entities': [],
'supported-continuation-in-entities': [],
'supported-incorporation-registration-entities': [],
Expand Down