Use TapActionCell's tintColor as its label textColor#13
Merged
Conversation
bcylin
approved these changes
Mar 20, 2018
Owner
bcylin
left a comment
There was a problem hiding this comment.
This is way better than the temporary button. Thank you very much 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix a pretty minor issue of
TapActionCell'stextLabelnot following the modifiedtintColorwhen setting a customtintColoron the application's mainUIWindowinstance (which is a somewhat common approach to theming the entire app).Since currently the text color is derived from a temporarily created button which is never inserted into the view hierarchy, it stays equal to the default system tint color, not the (potentially) overridden one.
After this change, the label's text color will follow its
TapActionCell'stintColorwhich sounds like intended and reasonable behavior to me.The downside is that overriding this text color via UIAppearance will now need to be done by manipulating
TapActionCell'stintColorproperty though the cell's appearance proxy, and not directly throughUILabel's proxy (since UIAppearance will notice the property having already been modified by the cell and will not proceed with update).