Skip to content

Assigning rows to RadioSection & Row protocol equatibility #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcylin merged 6 commits into from
Apr 10, 2018
Merged

Assigning rows to RadioSection & Row protocol equatibility #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1ec501
fixes issue when dynamically assigning rows in RadioSection, also fix…
z3bi Apr 7, 2018
f5a9293
fix equatable conformance
z3bi Apr 8, 2018
3501d36
declare row protocol as class protocol to allow for identity comparison
z3bi Apr 9, 2018
d994878
Merge branch 'develop' into develop
z3bi Apr 9, 2018
f31d62a
whitespace fix
z3bi Apr 9, 2018
64b0922
Merge branch 'develop' into develop
z3bi Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Model/RadioSection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ open class RadioSection: Section {
return options
}
set {
options = rows as? [OptionRowCompatible] ?? options
options = newValue as? [OptionRowCompatible] ?? options
Copy link
Copy Markdown
Owner

@bcylin bcylin Apr 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

}
}

Expand Down
2 changes: 1 addition & 1 deletion Source/Protocol/Row.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import Foundation

/// Any type that conforms to this protocol is capable of representing a row in a table view.
public protocol Row {
public protocol Row: class {

/// The title text of the row.
var title: String { get }
Expand Down