Add clippy linting and fix existing warnings#287
Merged
Conversation
Contributor
Author
|
You can already see the workflow in action (it cannot add the annotations currently, because this is only live on a fork). I think the lints should be required to pass, but I left it optional for now. Let me know what you think! |
Owner
|
Amazing!!! Thank you so much!! We've been meaning to do this for a while :P @all-contributors please add @niklasmohrin for code and bugs! |
Contributor
|
I've put up a pull request to add @niklasmohrin! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #276
I split the stuff up into separate commits, but I guess they could also be squashed.
I am not sure about the workflow as it uses some "secret token", but this is how it is set up over at
tealdeer. On the project page, it says that it is used to add the annotations to the PR diff. If you don't like that, I could replace it with a workflow that just checks the lints.