Using references in init_scripts() to avoid unnecessary .clone()s#618
Merged
Conversation
PsypherPunk
approved these changes
Aug 16, 2024
Collaborator
PsypherPunk
left a comment
PsypherPunk
left a comment
There was a problem hiding this comment.
Nice; I am entirely in favour of this.
Collaborator
|
@Arvmor, just sorting some failures in the build pipeline but this should be good to go. |
Contributor
Author
Great!! If anything comes up please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE
the
init_scripts()function includes a few unnecessary.clone()s which could be easily avoided through using references, the error handling is slightly verbose and if statements could also be less verbose by usingif let.https://github.com/RustScan/RustScan/blob/9f35cd43bc4124c479d54a0664503b6165fe9dfd/src/scripts/mod.rs#L129-L148
FIX
https://github.com/RustScan/RustScan/blob/033e2810f28be22610030e1974bf7fb351c9c4a6/src/scripts/mod.rs#L120-L135