build: remove release on pull-request#673
Merged
bee-san merged 1 commit intoNov 4, 2024
Merged
Conversation
- prevent running of the release workflow on pull-request: releases should only happen on explicit tagging. - tests etc. still run as part of the build workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly a suggestion at this point: Actions are currently failing due to the default
devtag being invalid for some parts of the release workflow.However, that raises the question as to whether it's appropriate to run a release workflow for a pull-request. I'm suggesting not herein and instead suggesting that this workflow is run only when explicitly tagged and the build workflow should be relied on for testing, etc.