Merged
Conversation
Collaborator
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
theospears
force-pushed
the
user-as-core-data
branch
2 times, most recently
from
fe88c19 to
b0ced8d
Compare
This was referenced Jan 8, 2024
Add user attributes null safe explicit implementation Update User object when user logs in and out Minimal working version Read values from CoreData Store the persistent container in a shared location Fix tests
theospears
force-pushed
the
user-as-core-data
branch
from
1aee601 to
fecf112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces usage of CoreData, and in particular starts to use it to store user information. For now, the information is also stored in preferences to allow undoing the change if needed. This is an experimental initial change, to evaulate also using CoreData for Goal and Datapoint information. This should eventually allow simpler data syncing between the main app and different extensions.
Testing:
Loaded the app and checked login state is persisted
Checked it is possible to log out and in
Check setting default alert start works