Goal view only sets suggested value once on load#442
Merged
theospears merged 1 commit intomasterfrom Feb 16, 2024
Merged
Conversation
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theospears and the rest of your teammates on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal screen tries to suggest a value based on recent past data.
In the past, this suggestion was updated every time the goal was updated/refreshed (as this might fetch new data). This lead to the user-selected value being overridden at annoying times, for example when navigating away from and returning to the app. Now instead we only set it once at load time. This might lead to stale values e.g. if goal data is out of date, but seems better than the previous behavior.
Testing:
Overrode the value, and checked pull to refresh did not change it
Checked switching away from the app and back did not change the value
Checked going back to the gallery and then back to the goal reset the value