Merged
Conversation
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theospears and the rest of your teammates on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goals in beeminder can be in a
queuedstate. This means while the client has the latest server data, the server has processing to do to update the state of the goal. Previously this state was not surfaced in the app. Here we update the app to show an animated bee over the graph when in this state. This matches the website behavior.Some refactoring is done to aid with this. A new component is introduced to render the lemniscate, and a new image view is introduced to consistently show the goal image, placeholder, and lemniscate, when appropriate. Some of the state machines here are somewhat intricate.
Testing:
Known bugs: