Refreshing gaols should only trigger a graph refresh for autodata goals#446
Merged
theospears merged 1 commit intomasterfrom Feb 23, 2024
Merged
Refreshing gaols should only trigger a graph refresh for autodata goals#446theospears merged 1 commit intomasterfrom
theospears merged 1 commit intomasterfrom
Conversation
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theospears and the rest of your teammates on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would trigger a graph refresh on reload for all goals. This wans't a big deal in the past because the UI didn't differentiate that state, but now we show a lemniscate for queued goals it means all pulls to refresh would trigger a lemniscate, making the refresh operation take several seconds to quiesce.
Now instead only trigger this refresh on goals with autodata, so manual goals refresh quicker.
Testing:
Refreshed a goal with autodata and saw the lemniscate
Refreshed a goal with manual data and saw no lemniscate