Merged
Conversation
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theospears and the rest of your teammates on |
theospears
force-pushed
the
remove-deltatext
branch
from
b4b57d5 to
9fdc7a0
Compare
theospears
force-pushed
the
remove-deltatext
branch
from
9fdc7a0 to
371937b
Compare
theospears
pushed a commit
that referenced
this pull request
Feb 24, 2025
) ## Summary Includes the due by table in the goal, displaying the deltas on the goal screen, where delta_text was previously displayed. The user can quickly see, at the goal screen, how many of a thing to do to obtain a number of days of safety. *For UI changes including screenshots of before and after is great.*  and now colored   ## Validation built and ran the app in the simulator viewed the goal screen of various goals Relates to #209 This shows the deltas on the goal screen. It does not display the entire table and it does not show the totals nor does it show the dates. It restores "amounts to do" previously provided by "delta text". (See #455) Fixes #559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app previously showed a section of numbers below the graph, e.g. (+1 +1 +2). These were from a time when "lanes" and "road" were part of the beeminder vocabulary and were pretty hard to understand, especially for do less goals.
We may wish to replace them with a table of what is due when, but for now just remove them.
Testing
Loaded the app and looked at a goal.