Consistently styled buttons#483
Conversation
|
I think it's possible this style will be divisive - personally I find it quite loud. But I'm happy to put it in a TestFlight build and collect feedback. Could you update the PR to merge cleanly, now I have merged the test fixes in #481 |
just proper casing for namespace
f4f2491 to
ed78101
Compare
|
I've merged this because I don't think it's a great use of time to tease it apart, but to set expectations, in the future I will not merge PRs which combine behavior changes (like the styling here) and widespread code style changes (like UIColor.beeminder -> UIColor.Beeminder) in the same PR. Small code style changes localized to only the places where there are behavior changes are ok. The reasons why are:
(I'm not looking for a discussion about whether or not this is the correct choice, just telling you the decision and giving some context.) |
Sure, let us try it. How about #489 |
This addresses the blemish as seen in the screenshot in #483 (comment). A square border is drawn around an otherwise rounded button. Now the border is also rounded.


Use a more consistent iOS styling for in app buttons.
Example:

See #481 (comment)