bump Gallery's collectionView to UICollectionViewDiffableDataSource#614
Merged
theospears merged 12 commits intobeeminder:masterfrom Jan 9, 2025
Merged
Conversation
These are more modern approaches to managing a collectionView's contents. As before, the collection shows a single section and merely displays all of the filtered goals in order.
krugerk
changed the title
This was referenced Jan 8, 2025
theospears
requested changes
Jan 8, 2025
Collaborator
theospears
left a comment
theospears
left a comment
There was a problem hiding this comment.
One major bug, and one question, but overall looks good.
I note this would have been much easier to review if the ICollectionView? -> `ICollectionView!' change had been a separate PR.
Co-authored-by: Theo Spears <github@theospears.com>
krugerk
commented
Jan 9, 2025
krugerk
commented
Jan 9, 2025
krugerk
commented
Jan 9, 2025
krugerk
commented
Jan 9, 2025
krugerk
commented
Jan 9, 2025
krugerk
commented
Jan 9, 2025
theospears
approved these changes
Jan 9, 2025
Collaborator
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrated the gallery's collection view to the more modern api, using diffable datasource and snapshots. See #607 (comment).
For UI changes including screenshots of before and after is great.
Transitions from one state to another (one set of goals to the next) is animated.
Validation
ran app in simulator, both iPhone and iPad (easier to see multiple columns and animation, for example, when filtering)
rotated simulator
changed sort preference
filtered on gallery's goals
signed out
signed in
navigated from gallery to goal and back
assured that some goal's data changed (for example safeBuf and safeSum) and the effect was seen in the cell at the same position