util.command_output: return stderr, too - #3329
Conversation
Return a namedtuple CommandOutput(stdout, stderr) instead of just stdout from util.command_ouput, allowing separate access to stdout and stderr. This change is required by the ffmpeg replaygain backend (GitHub PullRequest beetbox#3056) as ffmpeg's ebur128 filter outputs only to stderr.
|
I'm kind of lost with this test failure. The exception seems to originate in In this branch neither the bpd plugin, nor the space of available addresses has been changed. My best guess is that this is an existing bug that surfaces now due to unhappy timing (and would disappear when rerunning the tests). Any help? |
|
Looks like an unstable test - I just re-ran the tests for this branch on Travis and it has passed now 😕 |
|
Indeed; we do have problems with that test. There's more in #3309. |
sampsyo
left a comment
sampsyo
left a comment
There was a problem hiding this comment.
Looks good overall! Would you mind adding a quick note to the changelog under a "for developers" heading indicating that this API has changed, in case any external code is depending on it?
After commit `30395911 util.command_output: return stderr, too`, `command_output` returns a tuple of stdout and stderr. Document that change by adding a changelog entry and add a usage note to `command_output`'s docstring.
util.command_output: return stderr, too
|
Looks perfect. Thanks again for separating this out! Merged. ✨ |
3 participants
Return a namedtuple CommandOutput(stdout, stderr) instead of just stdout from
util.command_ouput, allowing separate access to stdout and stderr.
This change is required by the ffmpeg replaygain backend (GitHub
PullRequest #3056) as ffmpeg's ebur128 filter outputs only to stderr.