Fix #2080 - #3372
Conversation
sampsyo
left a comment
There was a problem hiding this comment.
Looks wonderful; thank you!! Really nice work on this.
I just have one small suggestion for the docs.
|
The tests revealed that we might need to add Those are listed in our Tox config: Lines 13 to 26 in 3ffd5ca |
|
Ah, I have thought before that the |
|
Perfect! Let me re-emphasize that we really appreciate your adding such extensive tests for the plugin. Wahoo! |
|
@temrix i just updated my beets install and i tried to import a test dir with few tracks and i get the following error:
|
|
Can you open a new issue with this? We can discuss there. And try to pin-point the track or at least a range of albums the error has occurred with. |
Original PR #3372 by temrix Original: beetbox/beets#3372
Merged from original PR #3372 Original: beetbox/beets#3372
This fixes feature request #2080 .
I have added
bpm,musical_keyandgenrein the beatport plugin. I needed to modify the hooks in the autotagger to accept those additional attributes.genrewill be fetched for each track. I have also added a test file to test the plugin.