discogs: restore strip of disambiguation number from artist - #3390
discogs: restore strip of disambiguation number from artist#3390kergoth wants to merge 1 commit into
Conversation
|
Without this fix, we get entries in the candidates list like this (note the |
5bf9d04 to
82febf1
Compare
|
I'm not sure how generally useful this get_artist method is going to be, but if we think it is, we might want to separate the 'get the list of artists' from the join, to let the caller manipulate the individual artists rather than only getting the merged string. |
The integration of MetadataSourcePlugin removed the strip, as it's discogs specific, but converted discogs to use it, which is a problem. Restore our own get_artist which makes the per-artist change we need. Signed-off-by: Christopher Larson <kergoth@gmail.com>
82febf1 to
3302253
Compare
|
Hey @kergoth you're right, I realized I mistakenly removed that bit of logic from but have added it back in #3389 over here. That PR also integrates it in the Beatport plugin, since the logic is identical. I don't anticipate this to be an issue for metadata sources which don't include disambiguation numbers, unless we actually encounter an artist named e.g. |
|
Ah, excellent, I didn’t notice that one. Thanks! |
The integration of MetadataSourcePlugin removed the strip, as it's
discogs specific, but converted discogs to use it, which is a problem.
Restore our own get_artist which makes the per-artist change we need.