Added schema variable and added more logging - #3449
Conversation
|
Thanks for pointing this out; this could obviously be better! I have a slightly different proposal to run by you: instead of the separate and varied config options |
Good idea. In that case, I'll make some changes and have you take a look again! |
|
Let me know what you think -- maybe needs other changes. Definitely need a documentation update. |
sampsyo
left a comment
sampsyo
left a comment
There was a problem hiding this comment.
Looking good; thanks for exploring this! I have a few suggestions within.
|
Oh wow... Sorry, I went quite a bit ahead before you commented. |
|
Okay! I'm done playing with it now if you want to take another review. Thanks! |
sampsyo
left a comment
sampsyo
left a comment
There was a problem hiding this comment.
Nice work! Here are just a few more organizational suggestions.
Also updated documentation to note the password options.
| pass: password | ||
| contextpath: /subsonic | ||
|
|
||
| \* NOTE: The pass config option can either be clear text or hex-encoded with a "enc:" prefix. |
There was a problem hiding this comment.
Cool! Buy maybe this sentence should go below, in the bullet for the pass configuration option, rather than by itself here.
|
Not sure if I understand the CI problems... Is it trying to download packages that it can't? I don't think my PR is related. |
sampsyo
left a comment
sampsyo
left a comment
There was a problem hiding this comment.
Awesome; this looks great!! Here are just a couple of very low-level suggestions. Also, would you mind adding a quick changelog entry to docs/changelog.rst?
| pass: password | ||
| contextpath: /subsonic | ||
|
|
||
| \* NOTE: The pass config option can either be clear text or hex-encoded with a "enc:" prefix. |
There was a problem hiding this comment.
Cool! Buy maybe this sentence should go below, in the bullet for the pass configuration option, rather than by itself here.
Added schema variable and added more logging
|
Awesome; thank you again for seeing this through to its conclusion! ✨ ✨ Merged with a changelog entry. |
|
Thanks for the support! It was fun doing Python for the first time. |
2 participants
Description
The plugin does a great job updating, but if I wanted to use the 443 port (https) it fails. Example, going to https://google:80 fails because it doesn't know how to forward this. So in the users' case, they would have to assume that giving port 80 in the config will forward to 443 using https properly. This just makes it more obvious.
I also added some more logs to make it more obvious to the user what's going on if they use the
--verboseoption. And if they don't, then it will send alog.infofor success cases.In terms of logging, I think I did this right. Please let me know if I didn't. Also first time contributing something in Python -- sorry if it doesn't look right. Let me know if I need to update anything!