Add artist_sort as the last entry in the artists to search - #3558
Conversation
This will handle cases where the artist name includes some characters which can cause a search failure for some websites - mainly unicode. Fixes #3340.
|
@sampsyo I've got this working. I was now looking to add tests and could figure out the new cases that will go into But I can see that there are also some integration tests which make actual network requests to verify things but it looks like they are testing the web scraping part (beautiful soup) instead of the actual plugin logic. What do you think I should do for this change? Is a new test case which verifies that the |
|
Nice! Looks great!! For this, I think just testing |
Adjust doc comment to highlight that artist_sort is used as a fallback
|
@sampsyo This looks good now. Let me know if there are any docs or changelogs that need editing. |
|
Looks perfect!! Merged with a quick changelog entry. ✨ |
This will handle cases where the artist name includes some
characters which can cause a search failure for some
websites - mainly unicode.
Fixes #3340.