Unignore flake8 E123, E126, E305, E741, W504 - #3669
Closed
arogl wants to merge 11 commits into
Closed
Conversation
none of these required any code changes
jtpavlock
reviewed
Jul 13, 2020
| ignore = | ||
| # pycodestyle errors | ||
| E121, # continuation line under-indented for hanging indent | ||
| # E121, # continuation line under-indented for hanging indent |
Contributor
There was a problem hiding this comment.
I think it makes sense to just remove them all together instead of keeping them around as a comment
Contributor
Author
There was a problem hiding this comment.
I agree removing them for final merge, but as noted below the tests still need to be changed.
Opening PR to start discussion.
I can get tests done tonight if no objections.
jtpavlock
reviewed
Jul 13, 2020
| ignore=E121,E123,E126,E24,E704,W503,W504,E305,C901,E221,E731,F405,FI50,FI51,FI12,FI53,FI14,FI15,E741 | ||
| min-version = 2.7 | ||
| accept-encodings = utf-8 | ||
| extend-exclude = test |
Contributor
There was a problem hiding this comment.
I don't think this would be good to merge in, as it would affect all linting for test files. I think these changes would have to be all or nothing for each error.
Contributor
Author
There was a problem hiding this comment.
Opening PR to start discussion.
I can get tests done tonight if no objections.
Contributor
Author
|
Can I do all of the tests in 1 merge? |
1 task
Contributor
Author
|
Closing in favour of #3672 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Un-ignore flake8 errors that require more than zero or minimal change to the codebase.
See the the discourse discussion
Uploading changes based on PR #3666 for discussion
I have ONLY updated the main branch not the tests as yet
Could use some help to put change back on my feature branch.