permissions: set album art permissions - #4036
Merged
Merged
Conversation
Member
|
Looks good overall; thanks!! I have a couple of comments:
|
Duncaen
force-pushed
the
permissions-art
branch
2 times, most recently
from
August 31, 2021 13:12
e1f60cb to
3377288
Compare
Member
|
This is looking good to me, what do you think @sampsyo ? |
sampsyo
approved these changes
Sep 12, 2021
sampsyo
left a comment
Member
There was a problem hiding this comment.
Thanks for the ping; yes, this all looks great! Nice work. Looks like it needs an update and then should be good to go.
Duncaen
force-pushed
the
permissions-art
branch
from
September 12, 2021 14:41
3377288 to
38e7fb4
Compare
Contributor
Author
|
Thanks, rebased and fixed the change log conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change makes the permissions plugin set the album art file permissions to the configurable file permissions whenever the
set_artevent is triggered.To Do
docs/to describe it.)docs/changelog.rstnear the top of the document.)