Add popularity tag by happiestbee · Pull Request #4102 · beetbox/beets

happiestbee · 2021-10-16T05:05:58Z

Get popularity tag for tracks from track api in Spotify plugin

Fixes #4094 .

Makes use of the popularity information for tracks

To Do

Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
Tests. (Encouraged but not strictly required.)

arsaboo · 2021-10-16T16:16:10Z

        'releasegroupdisambig': types.STRING,
        'disctitle': types.STRING,
        'encoder': types.STRING,
+        'popularity': types.INTEGER,


Wondering if we should use spotify_popularity as the label. LastFm also provides popularity values.

No problem, it should be changed now

sampsyo · 2021-10-16T23:40:55Z

Seems good overall to me! Can you also please add a changelog entry?

happiestbee · 2021-10-17T01:51:57Z

Seems good overall to me! Can you also please add a changelog entry?

Ok, that should be done

sampsyo

Thanks! Giving this a more thorough read a second time through, I see a couple of changes that would be useful. In particular, I think that the plugin should "own" this flexible attribute rather than having it baked into beets core. The plugin can provide the integer type for the field.

Also, to confirm, have you been able to try this feature out? That is, have you imported albums tagged with the spotify plugin and witnessed the field being set correctly? It can be useful to see things working at least once (in the absence of tests).

Co-authored-by: Adrian Sampson <adrian@radbox.org>

…into Add-popularity

sampsyo · 2021-10-25T14:02:49Z

Looking pretty good overall… when you get a chance, can you please confirm that this works for you?

happiestbee · 2021-10-25T18:22:30Z

Looking pretty good overall… when you get a chance, can you please confirm that this works for you?

I'm not sure how to test if it works or not

sampsyo · 2021-10-25T18:31:09Z

I think a good way would be to set up the plugin and try using it to tag some music.

happiestbee · 2021-10-26T04:58:42Z

Sorry I am not very familiar with this library. When I try tagging some music, it only provides the title and artist, even though it is marked as a recognized by Spotify. I am also unsure how to change the spotify plugin being used when I import beets to be the one with the relevant changes.

sampsyo · 2021-10-26T12:07:26Z

Well, you'll want to install the source code you have modified (something like pip install -e . can help with that). You can also try exploring the info plugin, which can dump out all the data for a given track after it's imported. (You might also consider calling on the people who originally requested this feature to help test it out.)

arsaboo · 2021-10-26T12:11:55Z

I am absolutely interested in testing it out, but not sure how to go about doing that :(

sampsyo · 2021-10-26T12:15:37Z

The FAQ has instructions for installing beets from source, which might be a good place to start.

arsaboo · 2021-10-26T14:45:11Z

Ok...so I tried it and here's the error that I am getting:

PS C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\Scripts> .\beet import "C:\Users\Alok\Downloads\Test"
Error: MusicBrainz not reachable in get release by ID with query 'b59f6b6e-b6e0-405f-a80c-a1859942a86e'
Traceback (most recent call last):
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.9_3.9.2032.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.9_3.9.2032.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\Scripts\beet.exe\__main__.py", line 7, in <module>
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\ui\__init__.py", line 1278, in main
    _raw_main(args)
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\ui\__init__.py", line 1265, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\ui\commands.py", line 973, in import_func
    import_files(lib, paths, query)
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\ui\commands.py", line 943, in import_files
    session.run()
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\importer.py", line 340, in run
    pl.run_parallel(QUEUE_SIZE)
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\util\pipeline.py", line 446, in run_parallel
    raise exc_info[1].with_traceback(exc_info[2])
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\util\pipeline.py", line 311, in run
    out = self.coro.send(msg)
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\util\pipeline.py", line 193, in coro
    func(*(args + (task,)))
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\importer.py", line 1376, in lookup_candidates
    task.lookup_candidates()
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\importer.py", line 660, in lookup_candidates
    autotag.tag_album(self.items, search_ids=self.search_ids)
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\autotag\match.py", line 461, in tag_album
    for matched_candidate in hooks.album_candidates(items,
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\plugins.py", line 573, in decorated
    for v in generator(*args, **kwargs):
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\autotag\hooks.py", line 629, in album_candidates
    yield from plugins.candidates(items, artist, album, va_likely,
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\plugins.py", line 384, in candidates
    yield from plugin.candidates(items, artist, album, va_likely,
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\plugins.py", line 733, in candidates
    albums = [self.album_for_id(album_id=r['id']) for r in results]
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beets\plugins.py", line 733, in <listcomp>
    albums = [self.album_for_id(album_id=r['id']) for r in results]
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beetsplug\spotify.py", line 200, in album_for_id
    track = self._get_track(track_data)
  File "C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\beetsplug\spotify.py", line 246, in _get_track
    spotify_popularity=track_data['popularity'],
KeyError: 'popularity'

happiestbee · 2021-10-26T14:57:12Z

Yeah I got that same error when testing but I'm not sure why that is happening.
Taking a look at the track_data argument, the response does not match the response shown in the spotify api get track response which is listed as the parameter type. So, while the response shown in the spotify api documentation has a popularity key for tracks, the actual response that the plugin gets does not. I'm not sure what is causing this difference.
The attached screenshot shows the track_data that the plugin is using, which is notably missing many keys

arsaboo · 2021-10-26T15:24:23Z

Ok...I did some more digging and looks like the popularity information may require an extra API call per track.

curl --request GET 'https://api.spotify.com/v1/tracks/6JUQViD0hLXlvWXCV4uUF8' --header "Authorization: Bearer XYZXYZ"
{
  "album" : {
    "album_type" : "album",
    "artists" : [ {
      "external_urls" : {
        "spotify" : "https://open.spotify.com/artist/0LyfQWJT6nXafLPZqxe9Of"
      },
      "href" : "https://api.spotify.com/v1/artists/0LyfQWJT6nXafLPZqxe9Of",
      "id" : "0LyfQWJT6nXafLPZqxe9Of",
      "name" : "Various Artists",
      "type" : "artist",
      "uri" : "spotify:artist:0LyfQWJT6nXafLPZqxe9Of"
    } ],
    "available_markets" : [ "AD", "AE", "AG", "AL", "AM", "AO", "AR", "AT", "AU", "AZ", "BA", "BB", "BD", "BE", "BF", "BG", "BH", "BI", "BJ", "BN", "BO", "BR", "BS", "BT", "BW", "BY", "BZ", "CA", "CH", "CI", "CL", "CM", "CO", "CR", "CV", "CW", "CY", "CZ", "DE", "DJ", "DK", "DM", "DO", "DZ", "EC", "EE", "EG", "ES", "FI", "FJ", "FM", "FR", "GA", "GB", "GD", "GE", "GH", "GM", "GN", "GQ", "GR", "GT", "GW", "GY", "HK", "HN", "HR", "HT", "HU", "ID", "IE", "IL", "IN", "IS", "IT", "JM", "JO", "JP", "KE", "KG", "KH", "KI", "KM", "KN", "KR", "KW", "KZ", "LA", "LB", "LC", "LI", "LK", "LR", "LS", "LT", "LU", "LV", "MA", "MC", "MD", "ME", "MG", "MH", "MK", "ML", "MN", "MO", "MR", "MT", "MU", "MV", "MW", "MX", "MY", "MZ", "NA", "NE", "NG", "NI", "NL", "NO", "NP", "NR", "NZ", "OM", "PA", "PE", "PG", "PH", "PK", "PL", "PS", "PT", "PW", "PY", "QA", "RO", "RS", "RU", "RW", "SA", "SB", "SC", "SE", "SG", "SI", "SK", "SL", "SM", "SN", "SR", "ST", "SV", "SZ", "TD", "TG", "TH", "TL", "TN", "TO", "TR", "TT", "TV", "TW", "TZ", "UA", "UG", "US", "UY", "UZ", "VC", "VN", "VU", "WS", "XK", "ZA", "ZM", "ZW" ],
    "external_urls" : {
      "spotify" : "https://open.spotify.com/album/2ifXB65SLpF97vWZjKGpQ9"
    },
    "href" : "https://api.spotify.com/v1/albums/2ifXB65SLpF97vWZjKGpQ9",
    "id" : "2ifXB65SLpF97vWZjKGpQ9",
    "images" : [ {
      "height" : 640,
      "url" : "https://i.scdn.co/image/ab67616d0000b273e4c77dc1b6c85c754f7f136c",
      "width" : 640
    }, {
      "height" : 300,
      "url" : "https://i.scdn.co/image/ab67616d00001e02e4c77dc1b6c85c754f7f136c",
      "width" : 300
    }, {
      "height" : 64,
      "url" : "https://i.scdn.co/image/ab67616d00004851e4c77dc1b6c85c754f7f136c",
      "width" : 64
    } ],
    "name" : "Shiddat",
    "release_date" : "2021-09-22",
    "release_date_precision" : "day",
    "total_tracks" : 7,
    "type" : "album",
    "uri" : "spotify:album:2ifXB65SLpF97vWZjKGpQ9"
  },
  "artists" : [ {
    "external_urls" : {
      "spotify" : "https://open.spotify.com/artist/3pQ4aA7dkolyjUAMrVScgh"
    },
    "href" : "https://api.spotify.com/v1/artists/3pQ4aA7dkolyjUAMrVScgh",
    "id" : "3pQ4aA7dkolyjUAMrVScgh",
    "name" : "Manan Bhardwaj",
    "type" : "artist",
    "uri" : "spotify:artist:3pQ4aA7dkolyjUAMrVScgh"
  } ],
  "available_markets" : [ "AD", "AE", "AG", "AL", "AM", "AO", "AR", "AT", "AU", "AZ", "BA", "BB", "BD", "BE", "BF", "BG", "BH", "BI", "BJ", "BN", "BO", "BR", "BS", "BT", "BW", "BY", "BZ", "CA", "CH", "CI", "CL", "CM", "CO", "CR", "CV", "CW", "CY", "CZ", "DE", "DJ", "DK", "DM", "DO", "DZ", "EC", "EE", "EG", "ES", "FI", "FJ", "FM", "FR", "GA", "GB", "GD", "GE", "GH", "GM", "GN", "GQ", "GR", "GT", "GW", "GY", "HK", "HN", "HR", "HT", "HU", "ID", "IE", "IL", "IN", "IS", "IT", "JM", "JO", "JP", "KE", "KG", "KH", "KI", "KM", "KN", "KR", "KW", "KZ", "LA", "LB", "LC", "LI", "LK", "LR", "LS", "LT", "LU", "LV", "MA", "MC", "MD", "ME", "MG", "MH", "MK", "ML", "MN", "MO", "MR", "MT", "MU", "MV", "MW", "MX", "MY", "MZ", "NA", "NE", "NG", "NI", "NL", "NO", "NP", "NR", "NZ", "OM", "PA", "PE", "PG", "PH", "PK", "PL", "PS", "PT", "PW", "PY", "QA", "RO", "RS", "RU", "RW", "SA", "SB", "SC", "SE", "SG", "SI", "SK", "SL", "SM", "SN", "SR", "ST", "SV", "SZ", "TD", "TG", "TH", "TL", "TN", "TO", "TR", "TT", "TV", "TW", "TZ", "UA", "UG", "US", "UY", "UZ", "VC", "VN", "VU", "WS", "XK", "ZA", "ZM", "ZW" ],
  "disc_number" : 1,
  "duration_ms" : 228189,
  "explicit" : false,
  "external_ids" : {
    "isrc" : "INS182101536"
  },
  "external_urls" : {
    "spotify" : "https://open.spotify.com/track/6JUQViD0hLXlvWXCV4uUF8"
  },
  "href" : "https://api.spotify.com/v1/tracks/6JUQViD0hLXlvWXCV4uUF8",
  "id" : "6JUQViD0hLXlvWXCV4uUF8",
  "is_local" : false,
  "name" : "Chitta",
  "popularity" : 64,
  "preview_url" : "https://p.scdn.co/mp3-preview/07ed17823a4678b9e7877caa85ab5c43952cfe8c?cid=3416be3c054d4a9a9ae55e3ef47ce3f9",
  "track_number" : 5,
  "type" : "track",
  "uri" : "spotify:track:6JUQViD0hLXlvWXCV4uUF8"

That information is not available in the album API call.

@rhlahuja indicated this in one of the closed threads. s/he was the last contributor to the Spotify plugin.

happiestbee · 2021-10-27T12:05:02Z

Ok I can quickly implement a track api call when iterating through the album response then. This will give access to a lot more information about each track

sampsyo · 2021-10-27T12:28:35Z

OK! As before, it would be great to hear about a demonstration that this has been tried and actually works.

It also adds an extra request per track, I think. That seems like it could slow things down a lot. Do we know how much? If it is indeed much slower, maybe this should be an option (off by default)?

arsaboo · 2021-10-27T12:31:19Z

Agreed on the track API call being optional (configurable). In addition, we need to be sure that this runs outside the importer with beet spotify

arsaboo · 2021-10-27T12:45:13Z

SO, I was able to run the updated code, but I did not see any new popularity field. See the output below (I have the info before and after the import):

PS C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\Scripts> .\beet info "C:\Users\Alok\Downloads\Test\Schedule (2021)\Schedule (2021) - Schedule.mp3"
C:\Users\Alok\Downloads\Test\Schedule (2021)\Schedule (2021) - Schedule.mp3
acoustid_fingerprint: AQADtNGehFKkCGl1fGnxB02P_DNcMYfoZBFc5cjyLUN4MYV-RHyqoJJ2PEmO5ujx-AiTD5qTPLjmIaSPMMuDXNiP_7BWHXGLi0dzBs9hRuzwGnmPA-6OfgGPK0Z-qMo3vAh1oumLfGqh6yPCPOg9nDNTWMtWcNcRMlWQnNiOOnqCpnqkoN9xD-4iXXiSBXKCZnxw9jj1DI2PD_3ROJGDWz--o1ZIHaF8DaqOPA_s49nxx9hz9BOJ_riWHA9znEf8BH8OLbVRSVHQnGD0pUdzPeiWHGdVvMhyHf5k7NHxCNfxpELzWHhx5MxxB33g5bFQ8tBzfIPKHE-OZkxInC_6McYhh8mDXDsmKR9-PBIHOzmqPBHyHZeoQF_WIqd49Dma0JmOjgqa8B2YP2he4kmigDdKDo8ZYuOF0keeIBll-AlatsH_4XKOK9HwzGikI3yM5BG-HU80qzhzGZ6oBF-MLxaS-4hlBdPqhjj2EBt6Fifx5cGRR4nxQs6HsDnsBq5y_PjhG5-NyWl2HP80PM-RS9Ay5NHxwnWOZDVyicWz4DzxHKF-6A-PdMxx4zucl4aTMg16vDjOaEJ0Zbh2PMfPoIeZDz9eMCmVC2qMUMcj5nhEvFPxg7_hF_2O6_iCpBmVIxt9NMT0oA-a3sgHkVxSHD8eJroCR8kjnAlG6kgTJqxw5XgOhtThd6j74BYS-4hFEs-yUPiFH00a5uiXIqtIDs9CE7eEH-HmwI50VFRe5FeH6hma59ATBmHaSGDm45ii60EX5nizIDwS7ol0tEv04BSF41mS6OjdoMkfJP-GYE9wqnj0DqWkB37RdcKP_JArhUKnT_CIypIF5oed4UWkrGbwhMOPn7AuxJKOJ8kL8R3uB3mUSiiVElP0BNx_HFP-oNZCBo8Q_hBZpQhJkrhzXDm-BQ199GKQdw6E6MfjglsOhkyeoPmCRyG-HDkJTXqMPDmcc-iNS7jOIZ8S6BOyZomy4fiNo6JzPPxAFWVfPKqFSzn-o9JnbFyiOEYyPkPey2j8oZSm4udRJT_-hQifTdCT5LiuowyaecB4HVU-NI2P__B8aA9zuPsR_bjCEOl4GsqDI0_QG3w17A-eTkes5pCPMKGPvunxXcgpQBP3IJ0yDdPKGO1yMPKPJOeF-wuaJjzqJj1-tEt0nAw0ZcejD4f2Ft4NrdtxJhgqppvgR6GE_niURNAptI-Rjvzx9Pjx4fE41LyQBz8j6GGU4y5iPjhdwbgkPCPapyo65cJzoZIH_9iTD-eDdJpiaE1CI3_Q54GT6orQRMeX40mIfNDyB30cfPlx08SYZUqR84h2U8YnHJfwJqOOXmFxBl5GQi126egTZ8iDTzgT5OGh-siSPRm-aEfTT3iPPkdTHU_C4hv4mAijMPOISZuOd4f2I73wPAh5Dp-U41qMJww0Hf-DJnoHPfxwPMYs5UHDzSjf4hKHJ4d-EpUZBU96-EVoLcGvFX2K7Rc8pgiZC3qQH81lVF5iIfehSnqQJ86J3xHhB7dwW_g95EcyJ-HR9Pg7fD36nAivVUiesDgVbehUNM-Dywn-4z90JUuOpsp19MKp49FRKyf-40tm4eKRRuSDnokK5ZEa9MgRMpkSsJcK_QniPIaj5Phw5Ug_Qc-RP6j0GE2HLzIqUkfzxhgvPUFyHWGIcqlxZcbR0DnK58iVHKJzIddx7aicXWjq4NqHSzkeNHUwIU6aQ0vG5QjZsQLjS3B1_EjFhKioyAZLycO5bDiRCzWHJlqi4_uQV4GWH7WOPI4OSsdzTDt8PkS3KEJMbdBOpGeKPrEU_HiKZ0GVE82ePIh_JBf24IrxREafJ_AnVehznDpy65ClMB7Kc0Iao5coMD_8BT5TTMySD5cq4c6RXzKcB7oi9XgupLuF0xS-KJgyhcnQVQLnHL2OLeJDVJxK5Amh_QjDKsVz4uJxZTr-o1E-I7wyBqp-5AoehdiDJuIT9Elo7MOuoc9lXBeeIw8s5YHGO0IoDnaYeLg2g-KPkksqXMOPZIlDI1eSHU2Irw_-BZ4OkhpyB-rxCArFaE3Q5oc4JaiOPCmaNV_REydJ4VESbUbPI83TQbuC6MlxFg_KJXkCh_vRT8F__Ph45GShoxLuI_0FxiOOVxLycAUP1VQThFFE5XiOJmxxHe8TOP5w58WX8vhRPoOXRU9Q5-AlE8mPdLzwRPnwg7GEZk-OJ9SD48_wI3YfJM7RZMWrH83Ri5fQlA-QM4d2EVeOh0dNdXiO5ih54QpL7HrxwqVSfNATi0FuCbuGpo6M8kZ_3MF_RCfELh9CJ8ePkkFz5ggPLU2SG3GmBz2HJl-KX8XD48hzaKl09A9y5fiPSlfR58ilyJiWfoFjhGdW_Gic41Iygcky4kuOJ18wXoGVxCryqdB8oflUIq8bNEzyYKI-PAx4oskx_cGT8PgR9oWW8cHDIz6eNUdD6gjP4s-RnBr2405xJTxeob-IKdeEy0FyIg-VDeXCY6RgHfGhXRX445E06JJ0RGhe9Htx40GtHs51BcnGI1aGP9iPHnYYMNeDS0cc9UgmkcEfTNaDBz-cRsPa6MQV5D60I02TCE7K4D1OPTAfnHjE4MlwHVZ1obqO7Mox59Cy4tSDVOYEH9WDXzyuo0dz5A6SOiqDJ0IlC7CY4tRw6cH6Bxd1QnwI8wpaHj_YHa4SBfxyXHmQ3D_C9MSTGc0k5qCPksmDX0WjacKZHPmHZNKD5qioJ3B1vEKYVBKu5GAzJgzOTCx-Ij-aUkFVvcjldIL6PEiPS5mLLgqTgMktPJj-oBmnB3kSDpp4pPNCtDuDh8d_nFOKv_Af5B-hI3oCQIkjUABGCELKGGI8A5IhRIBDCBggiBHMMEEVMc4JaIQAAiikAEAACWAAMMg4AhSzBgIiBBfCCo0YAsYQwAQCRBBBBQEAACEY4EIIBBBS1BAADEDAIAcRYQ4IBBAQjCkpGABCAMQAEEgg4BgxBghBAGFAIaAQIcwQAIhATjgFlVDEOKoQYsABwhxRChjGDFCGCEGQQhRoDpkAzDBAMHBAAWUAIowxAYhCSgkBtGMICgAYMcgQKZQAjgApgBCEAYuQABQQQiAQCEgBBEMACEIAMYAA45AREhFgiSNACGqEAogIQABBAAkEFGECOIIIEgRQBKQA0limhLEEKCGUQAYQYYBhBhADDEAAIIIQEYAwgBQQAiCAgBGGKgGQIUAgAQAyVggjACEACOIZcYiIQwARSjAAAAASWK6EJAAY5gRhgCEElBEMCCGMIEgghYQygABDANMECEMMARIxIRgQwjEhjELMGAIAMcwYAwiSQggCBEmEIEWAEAIBoQBCxEgCCCUAAGsEIJIAxowBBAkCEIAASCIEMABgIiwRgAEiABBISKKMUQRJBRxDhAAAABGICCEMMoIJI4wgSBqFDBCGeCccFcYYIJygQCggqECGAWAAMoQQAgQARAghCAOAEEAAMIAYRQggBiijAAOIEAEAAUYAQxwCUAhBFBUICQIAJxIIA4BThngkjAQcCCGMNIYYQYBggjAghBBKEAGKQEAZaQgxCAgCLAMGSGGIUQgAIpwjjgBJAMBAEEEEQAhRQQkQAjhnCDBGAOIMcEYCpgFBgiiCrHFCGIiQIQgoAoRDiDDAgBAGCAQEQUIhgIwADGABgAEGQAQQAU4I4AAxjApgCACKCEIAAIoAZxQhRBEqECHOACEwIsQAZhSAAhhhBDAAACIEo4ASgYggQACGEENEAAgEYEoxwgwRBAlkiECAAAcIEgQAQpwCwDDBAFBIAGCIIN4A
         acoustid_id: 23f8959b-5b64-4a1a-b8cb-e60f098112f1
               album: Schedule
         albumartist: Tegi Pannu\\Manni Sandhu
        albumartists:
           albumtype: single
            arranger:
                 art: True
              artist: Tegi Pannu, Manni Sandhu
             artists:
            bitdepth: 0
             bitrate: 320000
                 bpm: 0
            channels: 2
                comp: False
                date: 2021-08-20
                 day: 20
                disc: 1
           disctotal: 1
              format: MP3
               genre: Indi Pop
              genres: Indi Pop
               label: Collab Creations Ltd
              length: 148.4277551020408
              lyrics:
    mb_albumartistid: 78sIlhMniFgXlOrNWnPtIl
   mb_albumartistids: 78sIlhMniFgXlOrNWnPtIl
          mb_albumid: 0XtDEAGgkFrbNNaukE8pEF
         mb_artistid: 78sIlhMniFgXlOrNWnPtIl
        mb_artistids: 78sIlhMniFgXlOrNWnPtIl
          mb_trackid: 5eGsHi6RcL33gb9k89UYaB
               month: 8
       original_date: 2021-01-01
       original_year: 2021
          samplerate: 44100
               title: Schedule
               track: 1
          tracktotal: 1
                year: 2021
PS C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\Scripts> .\beet import "C:\Users\Alok\Downloads\Test"
Skipped 3 paths.

C:\Users\Alok\Downloads\Test\Schedule (2021) (1 items)
Finding tags for album "Tegi Pannu\\Manni Sandhu - Schedule".
Candidates:
1. Manni Sandhu - Makhaul (27.2%) (id, album, tracks, ...) (2015, GB, Collab Creations Ltd, CCDD00002)
2. Manni Sandhu - Door Ni Kulne (24.1%) (id, album, tracks, ...) (Digital Media, 2010, Brown Boi Music, GB-3LA-10-01012)
3. Manni Sandhu feat. Manjit Pappu - Friday (24.0%) (id, album, tracks, ...) (Digital Media, 2014, XW, Collab Creations Ltd, CCDD00001)
4. Manni Sandhu - Welcome to the Future (17.5%) (missing tracks, id, album, ...) (Digital Media, 2016, IN)
5. Manni Sandhu - My Time (13.2%) (missing tracks, id, album, ...) (CD, 2012, GB, Brown Boi Music)
# selection (default 1), Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort? e
Artist: tegi pannu
Album: schedule
Correcting tags from:
    Tegi Pannu\\Manni Sandhu - Schedule
To:
    Tegi Pannu, Manni Sandhu - Schedule
URL:
    https://open.spotify.com/album/0XtDEAGgkFrbNNaukE8pEF
(Similarity: 93.4%) (source, tracks) (Spotify, 2021, Collab Creations Ltd)
 * Schedule -> Schedule (source)
[A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort? a
PS C:\Users\Alok\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\Scripts> .\beet info "C:\Users\Alok\Downloads\Test\Schedule (2021)\Schedule (2021) - Schedule.mp3"
C:\Users\Alok\Downloads\Test\Schedule (2021)\Schedule (2021) - Schedule.mp3
acoustid_fingerprint: AQADtNGehFKkCGl1fGnxB02P_DNcMYfoZBFc5cjyLUN4MYV-RHyqoJJ2PEmO5ujx-AiTD5qTPLjmIaSPMMuDXNiP_7BWHXGLi0dzBs9hRuzwGnmPA-6OfgGPK0Z-qMo3vAh1oumLfGqh6yPCPOg9nDNTWMtWcNcRMlWQnNiOOnqCpnqkoN9xD-4iXXiSBXKCZnxw9jj1DI2PD_3ROJGDWz--o1ZIHaF8DaqOPA_s49nxx9hz9BOJ_riWHA9znEf8BH8OLbVRSVHQnGD0pUdzPeiWHGdVvMhyHf5k7NHxCNfxpELzWHhx5MxxB33g5bFQ8tBzfIPKHE-OZkxInC_6McYhh8mDXDsmKR9-PBIHOzmqPBHyHZeoQF_WIqd49Dma0JmOjgqa8B2YP2he4kmigDdKDo8ZYuOF0keeIBll-AlatsH_4XKOK9HwzGikI3yM5BG-HU80qzhzGZ6oBF-MLxaS-4hlBdPqhjj2EBt6Fifx5cGRR4nxQs6HsDnsBq5y_PjhG5-NyWl2HP80PM-RS9Ay5NHxwnWOZDVyicWz4DzxHKF-6A-PdMxx4zucl4aTMg16vDjOaEJ0Zbh2PMfPoIeZDz9eMCmVC2qMUMcj5nhEvFPxg7_hF_2O6_iCpBmVIxt9NMT0oA-a3sgHkVxSHD8eJroCR8kjnAlG6kgTJqxw5XgOhtThd6j74BYS-4hFEs-yUPiFH00a5uiXIqtIDs9CE7eEH-HmwI50VFRe5FeH6hma59ATBmHaSGDm45ii60EX5nizIDwS7ol0tEv04BSF41mS6OjdoMkfJP-GYE9wqnj0DqWkB37RdcKP_JArhUKnT_CIypIF5oed4UWkrGbwhMOPn7AuxJKOJ8kL8R3uB3mUSiiVElP0BNx_HFP-oNZCBo8Q_hBZpQhJkrhzXDm-BQ199GKQdw6E6MfjglsOhkyeoPmCRyG-HDkJTXqMPDmcc-iNS7jOIZ8S6BOyZomy4fiNo6JzPPxAFWVfPKqFSzn-o9JnbFyiOEYyPkPey2j8oZSm4udRJT_-hQifTdCT5LiuowyaecB4HVU-NI2P__B8aA9zuPsR_bjCEOl4GsqDI0_QG3w17A-eTkes5pCPMKGPvunxXcgpQBP3IJ0yDdPKGO1yMPKPJOeF-wuaJjzqJj1-tEt0nAw0ZcejD4f2Ft4NrdtxJhgqppvgR6GE_niURNAptI-Rjvzx9Pjx4fE41LyQBz8j6GGU4y5iPjhdwbgkPCPapyo65cJzoZIH_9iTD-eDdJpiaE1CI3_Q54GT6orQRMeX40mIfNDyB30cfPlx08SYZUqR84h2U8YnHJfwJqOOXmFxBl5GQi126egTZ8iDTzgT5OGh-siSPRm-aEfTT3iPPkdTHU_C4hv4mAijMPOISZuOd4f2I73wPAh5Dp-U41qMJww0Hf-DJnoHPfxwPMYs5UHDzSjf4hKHJ4d-EpUZBU96-EVoLcGvFX2K7Rc8pgiZC3qQH81lVF5iIfehSnqQJ86J3xHhB7dwW_g95EcyJ-HR9Pg7fD36nAivVUiesDgVbehUNM-Dywn-4z90JUuOpsp19MKp49FRKyf-40tm4eKRRuSDnokK5ZEa9MgRMpkSsJcK_QniPIaj5Phw5Ug_Qc-RP6j0GE2HLzIqUkfzxhgvPUFyHWGIcqlxZcbR0DnK58iVHKJzIddx7aicXWjq4NqHSzkeNHUwIU6aQ0vG5QjZsQLjS3B1_EjFhKioyAZLycO5bDiRCzWHJlqi4_uQV4GWH7WOPI4OSsdzTDt8PkS3KEJMbdBOpGeKPrEU_HiKZ0GVE82ePIh_JBf24IrxREafJ_AnVehznDpy65ClMB7Kc0Iao5coMD_8BT5TTMySD5cq4c6RXzKcB7oi9XgupLuF0xS-KJgyhcnQVQLnHL2OLeJDVJxK5Amh_QjDKsVz4uJxZTr-o1E-I7wyBqp-5AoehdiDJuIT9Elo7MOuoc9lXBeeIw8s5YHGO0IoDnaYeLg2g-KPkksqXMOPZIlDI1eSHU2Irw_-BZ4OkhpyB-rxCArFaE3Q5oc4JaiOPCmaNV_REydJ4VESbUbPI83TQbuC6MlxFg_KJXkCh_vRT8F__Ph45GShoxLuI_0FxiOOVxLycAUP1VQThFFE5XiOJmxxHe8TOP5w58WX8vhRPoOXRU9Q5-AlE8mPdLzwRPnwg7GEZk-OJ9SD48_wI3YfJM7RZMWrH83Ri5fQlA-QM4d2EVeOh0dNdXiO5ih54QpL7HrxwqVSfNATi0FuCbuGpo6M8kZ_3MF_RCfELh9CJ8ePkkFz5ggPLU2SG3GmBz2HJl-KX8XD48hzaKl09A9y5fiPSlfR58ilyJiWfoFjhGdW_Gic41Iygcky4kuOJ18wXoGVxCryqdB8oflUIq8bNEzyYKI-PAx4oskx_cGT8PgR9oWW8cHDIz6eNUdD6gjP4s-RnBr2405xJTxeob-IKdeEy0FyIg-VDeXCY6RgHfGhXRX445E06JJ0RGhe9Htx40GtHs51BcnGI1aGP9iPHnYYMNeDS0cc9UgmkcEfTNaDBz-cRsPa6MQV5D60I02TCE7K4D1OPTAfnHjE4MlwHVZ1obqO7Mox59Cy4tSDVOYEH9WDXzyuo0dz5A6SOiqDJ0IlC7CY4tRw6cH6Bxd1QnwI8wpaHj_YHa4SBfxyXHmQ3D_C9MSTGc0k5qCPksmDX0WjacKZHPmHZNKD5qioJ3B1vEKYVBKu5GAzJgzOTCx-Ij-aUkFVvcjldIL6PEiPS5mLLgqTgMktPJj-oBmnB3kSDpp4pPNCtDuDh8d_nFOKv_Af5B-hI3oCQIkjUABGCELKGGI8A5IhRIBDCBggiBHMMEEVMc4JaIQAAiikAEAACWAAMMg4AhSzBgIiBBfCCo0YAsYQwAQCRBBBBQEAACEY4EIIBBBS1BAADEDAIAcRYQ4IBBAQjCkpGABCAMQAEEgg4BgxBghBAGFAIaAQIcwQAIhATjgFlVDEOKoQYsABwhxRChjGDFCGCEGQQhRoDpkAzDBAMHBAAWUAIowxAYhCSgkBtGMICgAYMcgQKZQAjgApgBCEAYuQABQQQiAQCEgBBEMACEIAMYAA45AREhFgiSNACGqEAogIQABBAAkEFGECOIIIEgRQBKQA0limhLEEKCGUQAYQYYBhBhADDEAAIIIQEYAwgBQQAiCAgBGGKgGQIUAgAQAyVggjACEACOIZcYiIQwARSjAAAAASWK6EJAAY5gRhgCEElBEMCCGMIEgghYQygABDANMECEMMARIxIRgQwjEhjELMGAIAMcwYAwiSQggCBEmEIEWAEAIBoQBCxEgCCCUAAGsEIJIAxowBBAkCEIAASCIEMABgIiwRgAEiABBISKKMUQRJBRxDhAAAABGICCEMMoIJI4wgSBqFDBCGeCccFcYYIJygQCggqECGAWAAMoQQAgQARAghCAOAEEAAMIAYRQggBiijAAOIEAEAAUYAQxwCUAhBFBUICQIAJxIIA4BThngkjAQcCCGMNIYYQYBggjAghBBKEAGKQEAZaQgxCAgCLAMGSGGIUQgAIpwjjgBJAMBAEEEEQAhRQQkQAjhnCDBGAOIMcEYCpgFBgiiCrHFCGIiQIQgoAoRDiDDAgBAGCAQEQUIhgIwADGABgAEGQAQQAU4I4AAxjApgCACKCEIAAIoAZxQhRBEqECHOACEwIsQAZhSAAhhhBDAAACIEo4ASgYggQACGEENEAAgEYEoxwgwRBAlkiECAAAcIEgQAQpwCwDDBAFBIAGCIIN4A
         acoustid_id: 23f8959b-5b64-4a1a-b8cb-e60f098112f1
               album: Schedule
         albumartist: Tegi Pannu, Manni Sandhu
        albumartists:
           albumtype: single
            arranger:
                 art: True
              artist: Tegi Pannu, Manni Sandhu
             artists:
            bitdepth: 0
             bitrate: 320000
                 bpm: 0
            channels: 2
                comp: False
                date: 2021-08-20
                 day: 20
                disc: 1
           disctotal: 1
              format: MP3
               genre: Indi Pop
              genres: Indi Pop
               label: Collab Creations Ltd
              length: 148.4277551020408
              lyrics:
    mb_albumartistid: 78sIlhMniFgXlOrNWnPtIl
   mb_albumartistids: 78sIlhMniFgXlOrNWnPtIl
          mb_albumid: 0XtDEAGgkFrbNNaukE8pEF
         mb_artistid: 78sIlhMniFgXlOrNWnPtIl
        mb_artistids: 78sIlhMniFgXlOrNWnPtIl
          mb_trackid: 5eGsHi6RcL33gb9k89UYaB
               month: 8
       original_date: 2021-01-01
       original_year: 2021
          samplerate: 44100
               title: Schedule
               track: 1
          tracktotal: 1
                year: 2021

arsaboo · 2021-10-27T13:03:37Z

@happiestbee Can you confirm if you getting the popularity information? I can try again once I hear from you.

happiestbee · 2021-10-27T13:20:07Z

I believe it is working on my end

$ beet ls --format='$spotify_popularity'
73
$spotify_popularity
84
68
61
55
71
50
51
70
58
54
55
74
50
57
51
50
64
55
53
51
52
49
52
63
50
51
50
48
50
46
49

arsaboo · 2021-10-27T13:51:06Z

Indeed, I see those too. Looks like it is working

.\beet ls --format='$spotify_popularity'
0
0
0
0
1
1
0
0
0
0
0
0
0
0
1
0
0
0
71
0

For some reason I am not able to find the musiclibrary.blb file to browse the database on my test machine. Can you also see if you get that info with beet info

arsaboo · 2021-10-27T14:05:52Z

Ok...I see the information even in the database:

Wondering if this is the reason why it does not show in beet info as the information is saved in item_attributes table.

arsaboo · 2021-10-27T16:56:03Z

            medium_index=track_data['track_number'],
            data_source=self.data_source,
            data_url=track_data['external_urls']['spotify'],
+            spotify_popularity=track_data['popularity'],


I think this should be item.spotify_popularity so that the information is available in the items table. I also think it may be a good idea to save id while we are at it (similar to how MusicBrainz does it).

Maybe @sampsyo can confirm this before you make any changes.

I think you are right, I will go ahead and make the changes.

To clarify, is this what you mean?

def apply_item_metadata(item, track_info): """Set an item's metadata from its matched TrackInfo object. """ item.artist = track_info.artist item.artist_sort = track_info.artist_sort item.artist_credit = track_info.artist_credit item.title = track_info.title item.mb_trackid = track_info.track_id item.mb_releasetrackid = track_info.release_track_id item.spotify_popularity = track_info.spotify_popularity

happiestbee

These changes have been made

arsaboo · 2021-10-28T20:53:23Z

These changes have been made

Did you push those changes? I still see spotify_popularity=track_data['popularity'], in the code.

sampsyo · 2021-10-28T20:55:28Z

FWIW, changing apply_item_metadata should not be necessary. Values are already transferred from the TrackInfo object to the Item object here:

beets/beets/autotag/__init__.py

Line 92 in b8b74a7

item[field] = value

happiestbee · 2021-10-29T02:58:41Z

FWIW, changing apply_item_metadata should not be necessary. Values are already transferred from the TrackInfo object to the Item object here:

beets/beets/autotag/__init__.py

Line 92 in b8b74a7

item[field] = value

So is this feature fine the way it is right now?

arsaboo · 2021-10-29T12:45:33Z

FWIW, changing apply_item_metadata should not be necessary. Values are already transferred from the TrackInfo object to the Item object here:

beets/beets/autotag/__init__.py

Line 92 in b8b74a7

item[field] = value

But it is currently being added to the item_attributes table and not items. If item_attributes is the right place, then we are fine I guess.

sampsyo · 2021-10-29T13:12:49Z

It is indeed; that's where flexible (rather than fixed) attributes live.

happiestbee · 2021-10-29T13:15:28Z

FWIW, changing apply_item_metadata should not be necessary. Values are already transferred from the TrackInfo object to the Item object here:

beets/beets/autotag/__init__.py

Line 92 in b8b74a7

item[field] = value

But it is currently being added to the item_attributes table and not items. If item_attributes is the right place, then we are fine I guess.

So is this able to be merged?

sampsyo · 2021-10-29T13:19:26Z

Well, I would love to see a little more discussion (or implementation) on this point from above:

It also adds an extra request per track, I think. That seems like it could slow things down a lot. Do we know how much? If it is indeed much slower, maybe this should be an option (off by default)?

happiestbee · 2021-10-29T13:49:20Z

Well, I would love to see a little more discussion (or implementation) on this point from above:

It also adds an extra request per track, I think. That seems like it could slow things down a lot. Do we know how much? If it is indeed much slower, maybe this should be an option (off by default)?

I'm not sure where to implement this option since the autotagger is not a subcommand of the plugin

arsaboo · 2021-10-29T13:57:21Z

Well, I would love to see a little more discussion (or implementation) on this point from above:

It doesn't look like it is adding more calls right now. Currently, it is just gathering the information available at the time of import (which was available even earlier but was not stored).

happiestbee · 2021-10-29T14:05:37Z

Well, I would love to see a little more discussion (or implementation) on this point from above:

It doesn't look like it is adding more calls right now. Currently, it is just gathering the information available at the time of import (which was available even earlier but was not stored).

I did need to add a new call since the track info being passed was actually the track info contained in an album call, which does not contain all info such as the popularity of the track

arsaboo · 2021-10-30T13:29:29Z

While we are at it...can we also save the track_id (maybe part of items table)? We can then use the track_id to get other audio features (in a subsequent PR).

arsaboo · 2021-11-02T12:50:28Z

So, I tested this a little more and it looks like the track API will not work. I started getting 429 errors (API rate limit exceeded) and I am guessing it is because every track is triggering an API call and that can easily exceed the API rate limit for a large album. Instead of track API call, we should use tracks API call that allows multiple tracks (maximum of 50) to be called.

stale · 2022-03-06T03:16:37Z

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Add popularity tag

4c5629a

arsaboo reviewed Oct 16, 2021

View reviewed changes

Changed label

f64ef4a

happiestbee added 2 commits October 16, 2021 21:45

Delete trailing whitespace

18ffa48

Add changelog entry

9e2915b

sampsyo requested changes Oct 17, 2021

View reviewed changes

Comment thread docs/changelog.rst Outdated

Comment thread beets/library.py Outdated

Comment thread beets/autotag/hooks.py Outdated

happiestbee and others added 3 commits October 24, 2021 23:36

Update docs/changelog.rst

52207ac

Co-authored-by: Adrian Sampson <adrian@radbox.org>

Make changes to popularity

3a1736a

Merge branch 'Add-popularity' of https://github.com/happiestbee/beets …

105cf06

…into Add-popularity

kergoth mentioned this pull request Oct 26, 2021

Obtain popularity score from Spotify? kergoth/beets-kergoth#1

Closed

Add track api call

85be349

happiestbee requested a review from sampsyo October 27, 2021 12:26

arsaboo reviewed Oct 27, 2021

View reviewed changes

happiestbee commented Oct 28, 2021

View reviewed changes

stale Bot added the stale label Mar 6, 2022

stale Bot closed this Mar 13, 2022

arsaboo mentioned this pull request Jun 16, 2022

Add Spotify 429 (too many requests) API error handling #4370

Merged

3 tasks

Uh oh!

Conversation

happiestbee commented Oct 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Get popularity tag for tracks from track api in Spotify plugin

To Do

Uh oh!

arsaboo Oct 16, 2021

Choose a reason for hiding this comment

Uh oh!

happiestbee Oct 16, 2021

Choose a reason for hiding this comment

Uh oh!

sampsyo commented Oct 16, 2021

Uh oh!

happiestbee commented Oct 17, 2021

Uh oh!

sampsyo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sampsyo commented Oct 25, 2021

Uh oh!

happiestbee commented Oct 25, 2021

Uh oh!

sampsyo commented Oct 25, 2021

Uh oh!

happiestbee commented Oct 26, 2021

Uh oh!

sampsyo commented Oct 26, 2021

Uh oh!

arsaboo commented Oct 26, 2021

Uh oh!

sampsyo commented Oct 26, 2021

Uh oh!

arsaboo commented Oct 26, 2021

Uh oh!

happiestbee commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arsaboo commented Oct 26, 2021

Uh oh!

happiestbee commented Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sampsyo commented Oct 27, 2021

Uh oh!

arsaboo commented Oct 27, 2021

Uh oh!

arsaboo commented Oct 27, 2021

Uh oh!

arsaboo commented Oct 27, 2021

Uh oh!

happiestbee commented Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arsaboo commented Oct 27, 2021

Uh oh!

arsaboo commented Oct 27, 2021

Uh oh!

arsaboo Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

happiestbee Oct 28, 2021

Choose a reason for hiding this comment

Uh oh!

happiestbee Oct 28, 2021

Choose a reason for hiding this comment

Uh oh!

happiestbee left a comment

Choose a reason for hiding this comment

Uh oh!

arsaboo commented Oct 28, 2021

Uh oh!

sampsyo commented Oct 28, 2021

Uh oh!

happiestbee commented Oct 29, 2021

happiestbee commented Oct 16, 2021 •

edited

Loading

happiestbee commented Oct 26, 2021 •

edited

Loading

happiestbee commented Oct 27, 2021 •

edited

Loading

happiestbee commented Oct 27, 2021 •

edited

Loading

arsaboo Oct 27, 2021 •

edited

Loading