Conversation
This will be help with testing each of the documents which do not any more depend on the 'global' `current_app` and `request`. These two can now be provided at the time the objects are instantiated.
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
|
@Serene-Arc could you have a glance at this one? It should be an easy one! |
Serene-Arc
left a comment
Serene-Arc
left a comment
There was a problem hiding this comment.
I'm not the most familiar with aura as a part of beets but I looked through all the changes and nothing seems untoward. Nice deduplication of some of it, and it's great that we can use the dataclass attribute now! There's probably a couple other places that could use it.
You do have a change to setup.py which means that this is going to cause a conflict with #5266. I'll approve but won't merge; you can decide in what order to merge these two so that it doesn't cause problems.
|
Going to merge this one first. #5266 removes |
2 participants
In #4746 I was making a small adjustment in beetsplug/aura.py and found that the module wasn't tested. So this PR adds some high-level tests to act a safeguard for any future adjustments.