Ignore .editorconfig file included in the .csharpierignore file#1030
Merged
belav merged 4 commits intobelav:mainfrom Nov 23, 2023
Merged
Ignore .editorconfig file included in the .csharpierignore file#1030belav merged 4 commits intobelav:mainfrom
belav merged 4 commits intobelav:mainfrom
Conversation
Ignore .editorconfig files in .csharpierignore Ignore .editorconfig files in .csharpierignore
Collaborator
|
Looks like there are some formatting issues |
belav
added a commit
that referenced
this pull request
Nov 22, 2023
This is gonna cause conflicts with #1030
Collaborator
|
@sebastieng84 please format the files locally with CSharpier and commit the result when you have some time so we can merge this. |
belav
approved these changes
Nov 23, 2023
Owner
belav
left a comment
belav
left a comment
There was a problem hiding this comment.
I went ahead and formatted, everything else looks good. Thanks for the contribution!
belav
added a commit
that referenced
this pull request
Nov 23, 2023
This is gonna cause conflicts with #1030
belav
added a commit
that referenced
this pull request
Nov 23, 2023
* Optimize editorconfig lookups when piping files This is gonna cause conflicts with #1030 * self code review
Contributor
Author
|
@belav sorry my kid has been sick and I didn't get the chance to fix the formatting! Thanks for fixing it 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolves issue #1023.
Any .editorconfig file included in the .csharpierignore file will not be parsed. By default we ignore everything in node_modules, but it still tries to parse the .editconfig file.