fix: named serde default for supersedes_demotion#27
Open
Conversation
#[serde(default)] on supersedes_demotion resolved to f32::default() = 0.0 instead of the intended 0.40. Users with partial config.toml files got no demotion applied to superseded memories. Adds default_supersedes_demotion() helper following the existing pattern (default_recency_weight, default_child_rescue_only, etc.) and wires it via #[serde(default = "default_supersedes_demotion")]. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Liorrr has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[serde(default)]onsupersedes_demotionresolved tof32::default() = 0.0instead of the intended0.40config.tomlfiles got zero demotion applied to superseded memoriesdefault_supersedes_demotion()helper following the existing pattern (default_recency_weight,default_child_rescue_only, etc.)Test plan
cargo clippy -p shrimpk-core -- -D warningspasses (0 warnings)cargo test -p shrimpk-corepasses (91/91)cargo check --workspacepasses🤖 Generated with Claude Code