Use ES2015 classes for subcomponents instead of imported render functions#9
Use ES2015 classes for subcomponents instead of imported render functions#9cjb wants to merge 1 commit intobenoitvallon:masterfrom
Conversation
|
@cjb very very interesting approach. I am not going to merge it for 2 reasons (at least now). About the tests, they all passed and the react-native build too so I think your version works great. About merging, we will see in the future because this approach is so interesting and I think may also help to get a simpler structure when the android version will be merged because thinking in terms of components imbrication may be easier to understand. Thanks for your suggestion |
|
Cool, no worries. |
Hi! I know I recommended the Render.call() thing initially, but we've since discovered that you can just import a native class that extends Component and render that, which feels much more React-y, and allows the native subclass to override any method of Component (such as storing its own state if it wants to) rather than just Render().
Here's a PR that shows how that works. It's totally untested, though, please test carefully if you decide you'd like to merge! No worries if you decide you prefer the old method. I just thought I'd share.