Fix filing GetOrCreate could delete unrelated cache entries - #17
Merged
Conversation
When create() failed, Delete(key) removed whatever was currently at that key — even if another goroutine had since replaced it via Set() or GetOrCreate(). Now only deletes if the entry is the same instance.
bep
force-pushed
the
feat/claudereview
branch
from
January 14, 2026 00:32
70aa070 to
f9d7b79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When create() failed, Delete(key) removed whatever was currently at that key — even if another goroutine had since replaced it via Set() or GetOrCreate(). Now only deletes if the entry is the same instance.