Skip to content

Added allow anonymous dropdown select in edit instances #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peter-hank merged 6 commits into from
Jun 24, 2019
Merged

Added allow anonymous dropdown select in edit instances #124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4490796
Added allow anonymous dropdown select in edit instances
singhsanket143 Jun 9, 2019
f374ee7
Updated code formatting
singhsanket143 Jun 11, 2019
aa2feae
Refactored code
singhsanket143 Jun 19, 2019
057ca81
Completed refactoring of edit.html
singhsanket143 Jun 23, 2019
29b23d0
Rectified crash errors
singhsanket143 Jun 24, 2019
f78e1fc
Updated comments in edit.js
singhsanket143 Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions client/views/edit/edit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h1 class="formtitle">Edit</h1>
<div class="inputcontainer" style="text-align: center;">
<div class="dropdowncontainer">
<p class="dropdownlabel">Number of "featured" questions:</p>
<select name="threshold" size="1" value="4">
<select name="threshold" size="1" value="4">
<option value="2" {{isSelected "threshold" 2}}>2</option>
<option value="4" {{isSelected "threshold" 4}}>4</option>
<option value="6" {{isSelected "threshold" 6}}>6</option>
Expand Down Expand Up @@ -74,9 +74,16 @@ <h1 class="formtitle">Edit</h1>
<option value="off" {{isSelected "social" false}}>Off</option>
</select>
</div>
<div class="dropdowncontainer">
<p class="dropdownlabel">Allow anonymous:</p>
<select name="anonymous" size="1">
<option value="on" {{isSelected "anonymous" true}}>On</option>
<option value="off" {{isSelected "anonymous" false}}>Off</option>
</select>
</div>
<div class="editsubmitbutton">
Done
</div>
</div>
</div>
</template>
</template>
3 changes: 3 additions & 0 deletions client/views/edit/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Template.edit.events({
const stale = template.$('select[name=stale_length]').val();
const isHidden = (template.$('select[name=visibility]').val() === 'hidden');
const social = (template.$('select[name=social]').val() === 'on');
const anonymous = template.$("select[name=anonymous]").val() === "on"; // Fetch the anonymous value from the dropdown
const newValues = {
threshold: parseInt(threshold),
new_length: parseInt(redLength),
Expand All @@ -40,6 +41,7 @@ Template.edit.events({
max_response: parseInt(maxResponse),
hidden: isHidden,
social: social,
anonymous: anonymous
};
Meteor.call('editadv', table._id, newValues, (error, result) => {
if (error) {
Expand All @@ -51,6 +53,7 @@ Template.edit.events({
max_response: "Please enter a valid value in the 'Response max word count' drop down menu.",
hidden: "Please enter a valid value in the 'visibility of instance' drop down menu.",
social: "Please enter a valid value in the 'Social media sharing' drop down menu.",
anonymous: "Please enter a valid value in the 'Allow anonymous' drop down menu."
};
showEditAdvError(errorCodes[error.error]);
} else {
Expand Down