[Merged by Bors] - Add audio to ios example#1007
Closed
MichaelHills wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add audio to ios example#1007MichaelHills wants to merge 2 commits intobevyengine:mainfrom
MichaelHills wants to merge 2 commits intobevyengine:mainfrom
Conversation
karroffel
added
A-Audio
3 tasks
Member
|
@MichaelHills if you can verify that this still works I think this should be ready to be merged :) |
Contributor
Author
|
Oh CPAL needs a new version released with the iOS support. Then it should be trivial to rebase and land this. |
MichaelHills
force-pushed
the
mike-ios-example
branch
2 times, most recently
from
58009c5 to
4721279
Compare
Contributor
Author
|
Didn't realise cpal had done a release a month ago, just rebased and re-tested this works on sim + iphone 11. |
Contributor
Author
MichaelHills
force-pushed
the
mike-ios-example
branch
from
4721279 to
aed4048
Compare
Contributor
Author
|
@cart this is ready to go, I just retested simulator + my iPhone 11 and the mp3 plays in the background. Not sure anyone else is around to help test. |
Member
|
I trust you :) Thanks for doing this! |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 30, 2021
I'm still here :) will try to land the ios audio support in cpal soon and then we can land this. This PR also adds in assets as a directory reference and avoids the "Xcode is optimizing and breaking my PNGs" issue that I had earlier on during iOS testing on Bevy. Re-testing this now.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
I'm still here :) will try to land the ios audio support in cpal soon and then we can land this. This PR also adds in assets as a directory reference and avoids the "Xcode is optimizing and breaking my PNGs" issue that I had earlier on during iOS testing on Bevy. Re-testing this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still here :) will try to land the ios audio support in cpal soon and then we can land this.
This PR also adds in assets as a directory reference and avoids the "Xcode is optimizing and breaking my PNGs" issue that I had earlier on during iOS testing on Bevy.
Re-testing this now.