Skip to content

Flatten PrepassPipelineInternal into PrepassPipeline.#19909

Merged
alice-i-cecile merged 2 commits into
bevyengine:mainfrom
andriyDev:cleanup-prepass
Jul 1, 2025
Merged

Flatten PrepassPipelineInternal into PrepassPipeline.#19909
alice-i-cecile merged 2 commits into
bevyengine:mainfrom
andriyDev:cleanup-prepass

Conversation

@andriyDev
Copy link
Copy Markdown
Contributor

@andriyDev andriyDev commented Jul 1, 2025

Objective

  • PrepassPipelineInternal used to exist to optimize compile time and binary size when PrepassPipeline was generic over the material.
  • After Type erased materials #19667, PrepassPipeline is no longer generic!

Solution

  • Flatten all the fields of PrepassPipelineInternal into PrepassPipeline.

@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 1, 2025
@andriyDev andriyDev requested a review from tychedelia July 1, 2025 16:59
IceSentry
IceSentry approved these changes Jul 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI is fixed, LGTM

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 1, 2025
@andriyDev
Copy link
Copy Markdown
Contributor Author

andriyDev commented Jul 1, 2025 •
edited
Loading

RA didn't warn me about meshlet usages because they weren't in the default features :'(

Fixed.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 1, 2025
Merged via the queue into bevyengine:main with commit 1a410ef Jul 1, 2025
34 checks passed
@andriyDev andriyDev deleted the cleanup-prepass branch July 1, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tychedelia tychedelia Awaiting requested review from tychedelia

1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Rendering (Old)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andriyDev @IceSentry @alice-i-cecile