Use a local TBN in the solari BRDF#23948
Merged
Merged
Conversation
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Apr 23, 2026
alice-i-cecile
added
the
D-Straightforward
SparkyPotato
approved these changes
Apr 24, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
tychedelia
pushed a commit
to processing/bevy
that referenced
this pull request
Apr 30, 2026
# Objective BRDF fixes for solari. Split off from bevyengine#23818. ## Solution Use a local TBN instead of mikktspace, which was producing seams on the spheres used for the white furnace test. ## Testing On main: <img width="1920" height="1013" alt="1_main_F_AB" src="https://github.com/user-attachments/assets/c05acf43-faa1-4128-9cdc-807ed2364518" /> This PR: <img width="1920" height="1013" alt="2_proper_tbn" src="https://github.com/user-attachments/assets/7230e9d9-02ec-4435-8d74-1b7b7a314e27" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
BRDF fixes for solari. Split off from #23818.
Solution
Use a local TBN instead of mikktspace, which was producing seams on the spheres used for the white furnace test.
Testing
On main:
This PR:
