Improve energy conservation in the solari BRDF#24246
Merged
Merged
Conversation
kfc35
added
A-Rendering
kfc35
removed
the
S-Needs-Review
dylansechet
force-pushed
the
solari_brdf_mixing
branch
from
aaf0c60 to
3a5b380
Compare
Contributor
Author
|
I've rebased on main now that #24243 has been merged. |
JMS55
approved these changes
May 17, 2026
JMS55
left a comment
JMS55
left a comment
Contributor
There was a problem hiding this comment.
Lgtm! Thank you for breaking the PR up, it really helped review.
One small nit: Probably better to use mix() here for blending between dielectric and metals.
JMS55
added
the
S-Needs-Review
SparkyPotato
approved these changes
May 17, 2026
SparkyPotato
left a comment
SparkyPotato
left a comment
Contributor
There was a problem hiding this comment.
Looks good, after the mix suggestion
JMS55
added
S-Ready-For-Final-Review
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Member
|
Merge conflicts sorry. |
Contributor
Author
|
Conflicts fixed :) |
mockersf
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This PR is split off from #23818.
It depends on #24313, which is integrated as the first commit here.
There's an issue in the solari BRDF which causes partially metallic objects to lose energy in the white furnace test.
Solution
The current BRDF computes a blended F0 between metallic and dielectric materials, and then uses it it for calculations. It should be evaluating both the metallic and dielectric BRDFs separately and only blend them as a last step.
A similar issue used to be present for IBL and was fixed in the same way, see #23203.
Showcase
White furnace test
Main:
This PR:
