Open
Conversation
paolopas
changed the title
std::threds related macOS Xcode CI issues
paolopas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong with macOS Xcode 16.4 ?
My conclusion is that this is a problem with Python's
concurrent.futures.ProcessPoolExecutor(max_workers=None)when running thegrep(multithreaded) test. This causes the interpreter to hang and the tests to time out.The changes to the
test/test_all.pyfile alone are enough to work around the problem, it's simply a matter of moving thegreptest into theexclusive_testgroup, so that it is executed byProcessPoolExecutor(max_workers=1).However, the new implementation of
exec_cmdis more secure than the previous one, in the management of pipe file descriptors (used for IPC), in error checking and also in process signals management.Changes to
BoostBuild.pyshould be already in the main and have no impact.