Merged
Conversation
Contributor
williamzhuk
commented
Aug 5, 2024
williamzhuk
commented
- hashing instead of shortening
- csv.py renamed to csv_.py to avoid conflict with pandas internal csv.py
- used hashing of filenames instead of shortening - csv_ instead of csv to avoid potential issues with importing pandas (pandas can get confused as it has its own internal csv.py) - a bit of debugging of some issues
bghira
reviewed
Aug 6, 2024
bghira
reviewed
Aug 6, 2024
| if isinstance(location, str) or isinstance(location, Path): | ||
| if location not in self.df.index: | ||
| self.df.loc[location] = pd.Series() | ||
| location = path_to_hashed_path(location, self.hash_filenames) |
Owner
There was a problem hiding this comment.
can we update this method to use clone() before saving, like the local backend does?
bghira
reviewed
Aug 6, 2024
| from helpers.data_backend.local import LocalDataBackend | ||
| from helpers.data_backend.aws import S3DataBackend | ||
| from helpers.data_backend.csv import CSVDataBackend | ||
| from helpers.data_backend.csv_ import CSVDataBackend |
Owner
There was a problem hiding this comment.
i would prefer we call it csv_url_list if we're changing it
Owner
There was a problem hiding this comment.
Suggested change
| from helpers.data_backend.csv_ import CSVDataBackend | |
| from helpers.data_backend.csv_url import CSVDataBackend |
bghira
requested changes
Aug 6, 2024
Owner
bghira
left a comment
bghira
left a comment
There was a problem hiding this comment.
thanks for the updates, hashing things makes sense. but i'd like the comments resolved first 👍
Owner
|
i updated it to use file extensions instead of str_pattern to search. it still works. @williamzhuk can you follow-up with the other changes? |
Co-authored-by: Bagheera <59658056+bghira@users.noreply.github.com>
bghira
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.