Skip to content

feat: comparator default to Array.prototype.sort() behavior #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctjlewis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: comparator default to Array.prototype.sort() behavior #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export type Comparator<T> = (a: T, b: T) => number
* @param insertValue value to be added to the array
* @param comparator function that helps determine where to insert the value (
*/
export function binaryInsert<T>(array: T[], insertValue: T, comparator: Comparator<T>) {
export function binaryInsert<T>(array: T[], insertValue: T, comparator: Comparator<T> = (a, b) => a < b ? -1 : 1) {
/*
* These two conditional statements are not required, but will avoid the
* while loop below, potentially speeding up the insert by a decent amount.
Expand Down